fix: unskip tests #4682
Merged
fix: unskip tests #4682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
hpohekar,
mayankansys,
prmukherj and
seanpearsonuk
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unskips two previously disabled tests by updating their version constraints and removing skip markers, allowing them to run in the current test suite.
- Removed upper version constraint (
<26.1) from field data streaming test - Unskipped custom Python error test and updated minimum version to
>=26.1 - Added changelog entry documenting the test fixes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_field_data.py | Removed upper version limit to enable test for version 26.1+ |
| tests/test_error_handling.py | Removed skip marker and updated minimum version requirement |
| doc/changelog.d/4682.fixed.md | Added changelog entry for unskipped tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hpohekar
approved these changes
Dec 8, 2025
seanpearsonuk
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unskip couple of tests which are now passing.