fix: from_install #4689
fix: from_install #4689
Conversation
mkundu1
requested review from
hpohekar,
mayankansys,
prmukherj and
seanpearsonuk
as code owners
There was a problem hiding this comment.
Pull request overview
This PR fixes the from_install method by removing inadvertently added gRPC-related parameters (certificates_folder and insecure_mode) that were causing the method to fail. The changes restore the method to its intended standalone launcher functionality without gRPC configuration options.
Key Changes:
- Removed
certificates_folderandinsecure_modeparameters from thefrom_installmethod signature - Removed associated parameter documentation for the gRPC arguments
- Renamed test function for clarity and added a new dry-run test
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ansys/fluent/core/session_utilities.py | Removed gRPC parameters and their documentation from from_install method |
| tests/test_session.py | Renamed existing test for clarity and added new dry-run test coverage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@mkundu1 thanks. Will this fix be included in a future patch release? Especially since the bug is also present in earlier patch releases, e.g. |
Context
from_installmethod was failing as the gRPC arguments were inadvertently added to it.Change Summary
Remove the gRPC arguments in
from_install.Rationale
We may support the gRPC arguments in standalone launcher for development/testing purpose. For now, I've removed the unnecessary arguments.
Impact
from_installmethod will be fixed. I'll patch last couple of release versions also.