Skip to content

fix: Improve code quality #5469

fix: Improve code quality

fix: Improve code quality #5469

Workflow file for this run

name: GitHub CI
# run only on main branch. This avoids duplicated actions on PRs
on:
merge_group:
pull_request:
types: [opened, reopened, synchronize, edited, closed]
branches:
- main
- release/*
push:
tags:
- "v*"
branches:
- main
- release/*
env:
DOCKER_IMAGE_NAME: ghcr.io/ansys/prime
DOCKER_IMAGE_TAG: '26.1.0.dev30'
MAIN_PYTHON_VERSION: '3.13'
PACKAGE_NAME: 'ansys-meshing-prime'
PACKAGE_NAMESPACE: 'ansys.meshing.prime'
DOCUMENTATION_CNAME: 'prime.docs.pyansys.com'
RESET_IMAGE_CACHE: 0
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
update-changelog:
name: "Update CHANGELOG for new tag"
if: github.event_name == 'push' && contains(github.ref, 'refs/tags')
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
steps:
- uses: ansys/actions/doc-deploy-changelog@v10
with:
token: ${{ secrets.PYANSYS_CI_BOT_TOKEN }}
bot-user: ${{ secrets.PYANSYS_CI_BOT_USERNAME }}
bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
vulnerabilities:
name: Vulnerabilities
runs-on: ubuntu-latest
if: github.event.action != 'closed'
steps:
- uses: ansys/actions/check-vulnerabilities@v10
with:
python-version: ${{ env.MAIN_PYTHON_VERSION }}
token: ${{ secrets.PYANSYS_CI_BOT_TOKEN }}
python-package-name: ${{ env.PACKAGE_NAME }}
dev-mode: ${{ github.ref != 'refs/heads/main' }}
style:
name: Code style
if: github.event.action != 'closed'
runs-on: ubuntu-latest
steps:
- name: PyAnsys code style checks
uses: ansys/actions/code-style@v10
with:
python-version: ${{ env.MAIN_PYTHON_VERSION }}
vale-config: "doc/.vale.ini"
vale-version: "3.4.1"
docs-style:
name: Documentation Style Check
if: github.event.action != 'closed'
runs-on: ubuntu-latest
steps:
- name: PyAnsys documentation style checks
uses: ansys/actions/doc-style@v10
with:
token: ${{ secrets.GITHUB_TOKEN }}
smoke-tests:
name: Build and Smoke tests
if: github.event.action != 'closed'
runs-on: ${{ matrix.os }}
needs: [style]
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.10', '3.11', '3.12', '3.13']
should-release:
- ${{ github.event_name == 'push' && contains(github.ref, 'refs/tags') }}
exclude:
- should-release: false
os: macos-latest
steps:
- name: Build wheelhouse and perform smoke test
uses: ansys/actions/build-wheelhouse@v10
with:
library-name: ${{ env.PACKAGE_NAME }}
library-namespace: ${{ env.PACKAGE_NAMESPACE }}
operating-system: ${{ matrix.os }}
python-version: ${{ matrix.python-version }}
docs:
name: Documentation
if: github.event.action != 'closed'
runs-on: public-ubuntu-latest-16-cores
needs: [docs-style]
steps:
- name: Login in Github Container registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ansys-bot
password: ${{ secrets.GITHUB_TOKEN }}
- name: Pull, launch, and validate prime service
run: docker pull ${{ env.DOCKER_IMAGE_NAME }}:${{ env.DOCKER_IMAGE_TAG }}
- name: Setup headless display
uses: pyvista/setup-headless-display-action@v4
- name: "Run Ansys documentation building action"
uses: ansys/actions/doc-build@v10
with:
python-version: ${{ env.MAIN_PYTHON_VERSION }}
check-links: false
needs-quarto: true
sphinxopts: "-j auto --keep-going"
env:
PYVISTA_BUILDING_GALLERY: 'True'
PYPRIMEMESH_LAUNCH_CONTAINER: 1
PYPRIMEMESH_SPHINX_BUILD: 1
PYPRIMEMESH_IMAGE_TAG: ${{ env.DOCKER_IMAGE_TAG }}
ANSYSLMD_LICENSE_FILE: '1055@${{ secrets.LICENSE_SERVER }}'
# Commented out because too many PRs open cause the gh-pages branch to be too large
# doc-deploy-pr:
# name: "Deploy PR documentation"
# runs-on: ubuntu-latest
# needs: docs
# # Run when the PR is closed i.e. when docs job is skipped
# if: always() && (needs.docs.result == 'success' || needs.docs.result == 'skipped')
# steps:
# - uses: ansys/actions/doc-deploy-pr@v10
# with:
# cname: ${{ env.DOCUMENTATION_CNAME }}
# token: ${{ secrets.GITHUB_TOKEN }}
# bot-user: ${{ secrets.PYANSYS_CI_BOT_USERNAME }}
# bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
# maximum-pr-doc-deployments: 20
testing:
name: Run Unit Tests
if: github.event.action != 'closed'
needs: [ smoke-tests ]
runs-on: ubuntu-latest
steps:
- name: Login in Github Container registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ansys-bot
password: ${{ secrets.GITHUB_TOKEN }}
- name: Pull Ansys Prime Server
run: docker pull ${{ env.DOCKER_IMAGE_NAME }}:${{ env.DOCKER_IMAGE_TAG }}
- name: Restore images cache
uses: actions/cache@v5
with:
path: tests/graphics/image_cache
key: pyvista-image-cache-${{ runner.os }}-v-${{ env.RESET_IMAGE_CACHE }}-${{ hashFiles('pyproject.toml') }}
restore-keys: pyvista-image-cache-${{ runner.os }}-v-${{ env.RESET_IMAGE_CACHE }}
- name: "Run pytest"
uses: ansys/actions/tests-pytest@v10
env:
PYPRIMEMESH_LAUNCH_CONTAINER: 1
PYPRIMEMESH_IMAGE_TAG: ${{ env.DOCKER_IMAGE_TAG }}
ANSYSLMD_LICENSE_FILE: '1055@${{ secrets.LICENSE_SERVER }}'
with:
python-version: ${{ env.MAIN_PYTHON_VERSION }}
- name: Upload PyVista generated images (cache and results)
if: always()
uses: actions/upload-artifact@v6
with:
name: pytest-pyvista-images-${{ runner.os }}
path: tests/graphics/image_cache
retention-days: 7
- uses: codecov/codecov-action@v5
name: 'Upload coverage to CodeCov'
package:
name: Package library
if: github.event.action != 'closed'
needs: [testing, docs]
runs-on: ubuntu-latest
steps:
- name: Build library source and wheel artifacts
uses: ansys/actions/build-library@v10
with:
library-name: ${{ env.PACKAGE_NAME }}
python-version: ${{ env.MAIN_PYTHON_VERSION }}
release:
name: Release project
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
needs: [package, update-changelog]
runs-on: ubuntu-latest
environment: release
permissions:
id-token: write
contents: write
steps:
- name: "Download the library artifacts from package step"
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
with:
name: ${{ env.PACKAGE_NAME }}-artifacts
path: ${{ env.PACKAGE_NAME }}-artifacts
- name: "Upload artifacts to PyPI using trusted publisher"
uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # v1.13.0
with:
print-hash: true
packages-dir: ${{ env.PACKAGE_NAME }}-artifacts
- name: Release to GitHub
uses: ansys/actions/release-github@v10
with:
token: ${{ secrets.GITHUB_TOKEN }}
library-name: ${{ env.PACKAGE_NAME }}
upload_dev_docs:
name: Upload dev documentation
if: github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
needs: [package]
steps:
- name: Deploy the latest documentation
uses: ansys/actions/doc-deploy-dev@v10
with:
cname: ${{ env.DOCUMENTATION_CNAME }}
token: ${{ secrets.PYANSYS_CI_BOT_TOKEN }}
bot-user: ${{ secrets.PYANSYS_CI_BOT_USERNAME }}
bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
upload_docs_release:
name: Upload release documentation
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && !contains(github.ref, 'dev')
runs-on: ubuntu-latest
needs: [release]
steps:
- name: Deploy the stable documentation
uses: ansys/actions/doc-deploy-stable@v10
with:
cname: ${{ env.DOCUMENTATION_CNAME }}
token: ${{ secrets.PYANSYS_CI_BOT_TOKEN }}
bot-user: ${{ secrets.PYANSYS_CI_BOT_USERNAME }}
bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
python-version: ${{ env.MAIN_PYTHON_VERSION }}