fix: preserve code_execution_result fields during union round-trip unmarshaling#330
Open
Aaravanand00 wants to merge 1 commit into
Open
fix: preserve code_execution_result fields during union round-trip unmarshaling#330Aaravanand00 wants to merge 1 commit into
Aaravanand00 wants to merge 1 commit into
Conversation
…nion.UnmarshalJSON and harden round-trip tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s this fixing?
The issue turned out to be in union unmarshaling, not
ToParam().code_execution_resultfields (stdout,stderr,return_code) were getting dropped during a round-trip because the discriminator wasn’t handled properly.What changed?
CodeExecutionToolResultBlockParamContentUnion.UnmarshalJSONtypeNotes
ToParam()