feat(bedrock): support AWS_BEARER_TOKEN_BEDROCK env var

[davidmhewitt]

Fixes #1079

[karpetrosyan]

I think adding api_key as a client argument and defaulting to that environment variable would be better than only supporting it through the environment variable

[davidmhewitt]

Sure, I've added it as the last argument to to the client constructor to preserve the existing ordering. Let me know if that makes sense, given the _strict_response_validation arg (and associated comment) above it.

[karpetrosyan]

LGTM! Note that it also needs ruff format. Could you please run/commit it?

[RobertCraigie]

Do you know why the AWS naming around this functionality is inconsistent? i.e. why is the env var "bearer token" but the actual value is an "api key"?

[davidmhewitt]

Do you know why the AWS naming around this functionality is inconsistent? i.e. why is the env var "bearer token" but the actual value is an "api key"?

Not sure!

I would guess they called it API key on the user-facing docs side to be consistent with other LLM providers that use that terminology. Then someone implementing the feature in the SDK decided to name the env var in the way that describes the way the token is transported 🤷‍♂️

I'd be happy to rename all the variables/params to one or the other here if it helps

[devstein]

@davidmhewitt thank you for contributing this! I would love to see this merged.

[RiccardoRubini]

Thanks a lot @davidmhewitt. This is a very needed feature. Hope it will be merged soon

[fritz-astronomer]

Thanks! Would also love to see this merged.

[karpetrosyan]

@RobertCraigie Friendly ping on this! We could also rename api_key to aws_bearer_token to match AWS naming, instead of adapting their naming to match ours

[maxa-adrian-blandin]

Thanks! Could it be approved and merged? :)

EDIT: for anyone that might stumble on this PR, it's now supported.
See

anthropic-sdk-python/src/anthropic/lib/bedrock/_client.py

Lines 136 to 162 in 717f90b

	def __init__(
	self,
	aws_secret_key: str | None = None,
	aws_access_key: str | None = None,
	aws_region: str | None = None,
	aws_profile: str | None = None,
	aws_session_token: str | None = None,
	api_key: str | None = None,
	base_url: str | httpx.URL | None = None,
	timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
	max_retries: int = DEFAULT_MAX_RETRIES,
	default_headers: Mapping[str, str] | None = None,
	default_query: Mapping[str, object] | None = None,
	# Configure a custom httpx client. See the [httpx documentation](https://www.python-httpx.org/api/#client) for more details.
	http_client: httpx.Client | None = None,
	# Enable or disable schema validation for data returned by the API.
	# When enabled an error APIResponseValidationError is raised
	# if the API responds with invalid data for the expected schema.
	#
	# This parameter may be removed or changed in the future.
	# If you rely on this feature, please open a GitHub issue
	# outlining your use-case to help us decide if it should be
	# part of our public interface in the future.
	_strict_response_validation: bool = False,
	) -> None:
	if api_key is None:
	api_key = os.environ.get("AWS_BEARER_TOKEN_BEDROCK")

[localden]

Thank you for the PR - this was already addressed on main - see src/anthropic/lib/bedrock/_client.py:161. Closing as resolved.