On SIGINT the databases are not removed

[apendua]

The test databases are not removed when we SIGINT the current process. Lets think about the best pattern to overcome this problem.

Basically, the dilemma comes from the fact that we also need to teardown mongo processes but dropping database will only work before those processes are killed. On the other hand managing this type of synchronization when the process is about to exit is not an obvious task. So I was thinking that we could at least print some warning message to the user, telling them which files needs to be removed.

[arunoda]

In laika, it triggers a script which cleans dbs when starting up.
see: https://github.com/arunoda/laika/blob/master/bin/_laika#L222

On Wed Jan 28 2015 at 2:51:55 PM Tomasz Lenarcik notifications@github.com
wrote:

The test databases are not removed when we SIGINT the current process.
Lets think about the best pattern to overcome this problem.

Basically, the dilemma comes from the fact that we also need to teardown
mongo processes but dropping database will only work before those processes
are killed. On the other hand managing this type of synchronization when
the process is about to exit is not an obvious task. So I was thinking that
we could at least print some warning message to the user, telling them
which files needs to be removed.

—
Reply to this email directly or view it on GitHub
#85.

[apendua]

@arunoda Ha! That's clever. As long as maintain the names of DBs that need to be removed we may think about implementing a similar functionality.

BTW, these databases are always cleared if the process exits normally. They only remain on SIGINT and probably on UncoughtError.

[arunoda]

Yes. That was the same reason, I did this.
it's a simple mongo script:
https://github.com/arunoda/laika/blob/master/scripts/drop-laika-dbs.js
All we need it to create dbs with a prefix.
On Wed Jan 28 2015 at 2:59:25 PM Tomasz Lenarcik notifications@github.com
wrote:

@arunoda https://github.com/arunoda Ha! That's clever. As long as
maintain the names of DBs that need to be removed we may think about
implementing a similar functionality.

BTW, these databases are always cleared if the process exits normally.
They only remain on SIGINT and probably on UncoughtError.

—
Reply to this email directly or view it on GitHub
#85 (comment).

[welelay]

I'd rather see the database cleaned-up on startup: this way I can have a look at the db post-mortem to help debug failed tests.

[apendua]

@welelay Interesting point ... we could in fact allow this as an option. But I still think that removing database should be the default behavior, or otherwise you will end up with a ton of unnecessary files on your disk.

[welelay]

You mean tons of unnecessary files stay on disk in-between test runs ? That's a good point, though I'm not too concerned about that disk space because there must be enough disk space to be able to run the tests anyway.
Also, I agree that it shall not be the default.