Skip to content

Commit 82c4a30

Browse files
committed
remove support for reproduce in gh actions
1 parent 8eb6ee0 commit 82c4a30

4 files changed

Lines changed: 5 additions & 10 deletions

File tree

.claude/settings.local.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
22
"permissions": {
33
"allow": [
4-
"Bash(npm run *)"
4+
"Bash(npm run *)",
5+
"Bash(npx tsc *)"
56
]
67
}
78
}

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,13 @@ Chrome is only installed when `driver: browser`.
6767
| `origin` | Starting URL (also the navigation boundary). **Required.** | |
6868
| `spec` | Path to a TS/JS specification file. | |
6969
| `output-path` | Where to store trace, screenshots, etc. | |
70-
| `time-limit` | Maximum run time. Accepts `30s`, `5m`, `2h`, `1d`. **Required** unless `reproduce` is set. | |
70+
| `time-limit` | Maximum run time. Accepts `30s`, `5m`, `2h`, `1d`. **Required.** | |
7171
| `exit-on-violation` | Exit on the first failing property. | `false` |
7272
| `width` / `height` | Viewport size in pixels. | `1024` / `768` |
7373
| `device-scale-factor` | Viewport scaling factor. | `2` |
7474
| `instrument-javascript` | Comma-separated: `files`, `inline`. | `files,inline` |
7575
| `chrome-grant-permissions` | Comma-separated Chrome permissions. | (see manual) |
7676
| `headers` | HTTP headers as multi-line `Key: Value`. See below. | |
77-
| `reproduce` | Path to a trace file to reproduce. Mutually exclusive with `time-limit` / `exit-on-violation`. | |
7877
| `headless` | Run Chrome headless. | `true` |
7978
| `no-sandbox` | Disable Chromium sandboxing. Defaults on because GitHub-hosted Ubuntu runners restrict the namespaces Chromium needs. | `true` |
8079
| `chrome-version` | Channel (`stable`, `beta`, `dev`, `canary`) or specific build ID. | `stable` |

action.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ inputs:
4141
required: false
4242
default: 'false'
4343
time-limit:
44-
description: 'Maximum time to run the test, e.g. `30s`, `5m`, `2h`, `1d`. Required for the browser driver unless `reproduce` is set. Should be shorter than the job''s `timeout-minutes` so bombadil can exit cleanly and emit its trace.'
44+
description: 'Maximum time to run the test, e.g. `30s`, `5m`, `2h`, `1d`. Required for the browser driver. Should be shorter than the job''s `timeout-minutes` so bombadil can exit cleanly and emit its trace.'
4545
required: false
4646
width:
4747
description: 'Browser viewport width in pixels.'
@@ -61,9 +61,6 @@ inputs:
6161
headers:
6262
description: 'Extra HTTP headers to send with all browser requests. One `Key: Value` per line.'
6363
required: false
64-
reproduce:
65-
description: 'Reproduce a previous test run from a trace file. Mutually exclusive with `time-limit` and `exit-on-violation`.'
66-
required: false
6764
headless:
6865
description: 'Run the browser headless (no visible window).'
6966
required: false

src/main.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,15 +114,13 @@ async function run(): Promise<void> {
114114

115115
if (driver === 'browser') {
116116
const timeLimit = core.getInput('time-limit');
117-
const reproduce = core.getInput('reproduce');
118-
if (timeLimit.trim() === '' && reproduce.trim() === '') {
117+
if (timeLimit.trim() === '') {
119118
throw new Error(
120119
'The `time-limit` input is required for the browser driver (e.g. `30s`, `5m`, `2h`). Without it the test runs until the job timeout, even when `exit-on-violation` is true.',
121120
);
122121
}
123122
pushFlag(flags, '--output-path', core.getInput('output-path'));
124123
pushFlag(flags, '--time-limit', timeLimit);
125-
pushFlag(flags, '--reproduce', reproduce);
126124
pushBoolFlag(flags, '--exit-on-violation', core.getInput('exit-on-violation'), 'exit-on-violation');
127125
pushFlag(flags, '--width', core.getInput('width'));
128126
pushFlag(flags, '--height', core.getInput('height'));

0 commit comments

Comments
 (0)