Skip to content

Commit 2b92a2a

Browse files
committed
Test with single Verilator version
Signed-off-by: Krzysztof Bieganski <[email protected]>
1 parent b2c0d0b commit 2b92a2a

File tree

3 files changed

+1
-21
lines changed

3 files changed

+1
-21
lines changed

.github/Dockerfile

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,17 @@
11
FROM ubuntu:22.04
22

33
ARG VERILATOR_VERSION
4-
ARG VERILATOR_UVM_VERSION
54
ARG OPENOCD_VERSION
65
ARG RENODE_VERSION
76
ARG SPIKE_VERSION
87

98
ENV VERILATOR_VERSION=$VERILATOR_VERSION
10-
ENV VERILATOR_UVM_VERSION=$VERILATOR_UVM_VERSION
119
ENV OPENOCD_VERSION=$OPENOCD_VERSION
1210
ENV RENODE_VERSION=$RENODE_VERSION
1311
ENV SPIKE_VERSION=$SPIKE_VERSION
1412

1513
# All versions shall be stated explicitly
1614
RUN : "${VERILATOR_VERSION:?Environment variable VERILATOR_VERSION is not set or empty}" && \
17-
: "${VERILATOR_UVM_VERSION:?Environment variable VERILATOR_UVM_VERSION is not set or empty}" && \
1815
: "${OPENOCD_VERSION:?Environment variable OPENOCD_VERSION is not set or empty}" && \
1916
: "${RENODE_VERSION:?Environment variable RENODE_VERSION is not set or empty}" && \
2017
: "${SPIKE_VERSION:?Environment variable SPIKE_VERSION is not set or empty}"
@@ -72,20 +69,6 @@ RUN git clone https://github.com/antmicro/verilator verilator && \
7269
cd .. && \
7370
rm -rf verilator
7471

75-
# TODO We're using a separate version of verilator for uvm tests.
76-
# TODO Handle this properly.
77-
# TODO We may use docker compose or at least clean the previous tree and rebuild instead of cloning again.
78-
# Clone and build Verilator (UVM)
79-
RUN git clone https://github.com/verilator/verilator verilator && \
80-
cd verilator && \
81-
git checkout ${VERILATOR_UVM_VERSION} && \
82-
autoconf && \
83-
./configure --prefix=/opt/verilator_uvm && \
84-
make -j $(nproc) && \
85-
make install && \
86-
cd .. && \
87-
rm -rf verilator
88-
8972
# Clone and build OpenOCD
9073
RUN git clone https://github.com/antmicro/openocd openocd && \
9174
cd openocd && \
@@ -130,7 +113,6 @@ RUN git clone https://github.com/riscv-software-src/riscv-isa-sim spike && \
130113
ENV PATH="$PATH:/opt/renode:/opt/verilator/bin:/opt/openocd/bin:/opt/spike/bin"
131114

132115
RUN verilator --version
133-
RUN /opt/verilator_uvm/bin/verilator --version
134116
RUN openocd --version
135117
RUN renode --version
136118
RUN spike 2>&1 | head -n1

.github/workflows/build-docker-image.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ jobs:
1111
runs-on: ubuntu-20.04
1212
env:
1313
VERILATOR_VERSION: dont-skip-genblocks
14-
VERILATOR_UVM_VERSION: 7ca2d6470a
1514
OPENOCD_VERSION: riscv-nohalt-rebase
1615
RENODE_VERSION: 1.15.3+20240924gitc7bc336bb
1716
SPIKE_VERSION: d70ea67d
@@ -48,7 +47,6 @@ jobs:
4847
file: .github/Dockerfile
4948
build-args: |
5049
VERILATOR_VERSION=${{ env.VERILATOR_VERSION }}
51-
VERILATOR_UVM_VERSION=${{ env.VERILATOR_UVM_VERSION }}
5250
OPENOCD_VERSION=${{ env.OPENOCD_VERSION }}
5351
RENODE_VERSION=${{ env.RENODE_VERSION }}
5452
SPIKE_VERSION=${{ env.SPIKE_VERSION }}

.github/workflows/test-uvm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
2525
- name: Setup environment
2626
run: |
27-
echo "/opt/verilator_uvm/bin" >> $GITHUB_PATH
27+
echo "/opt/verilator/bin" >> $GITHUB_PATH
2828
RV_ROOT=`pwd`
2929
echo "RV_ROOT=$RV_ROOT" >> $GITHUB_ENV
3030
PYTHONUNBUFFERED=1

0 commit comments

Comments
 (0)