fix: normalize tgz path

Author: antongolub

config.json

@@ -33,8 +33,8 @@
         "version": "< 1.0.0"
       },
       {
-        "policy": "deny",
-        "dateRange": ["2010-01-01T00:00:00.000Z", "2025-01-01T00:00:00.000Z"]
+        "policy": "allow",
+        "_dateRange": ["2010-01-01T00:00:00.000Z", "2025-01-01T00:00:00.000Z"]
       }
     ]
   }

src/main/js/app.js

@@ -21,7 +21,7 @@ export const createApp = (cfg) => {
       [
         '*',
         [
-          /^\/(((@[a-z0-9\-]+)(%2f|\/))?[a-z0-9\-]+)\/-\/[a-z0-9\-]+-(\d+\.\d+\.\d+(?:-.+)?)\.tgz$/,
+          /^\/(((@[a-z0-9\-]+)(%2f|\/))?[a-z0-9\-]+)\/-\/[a-z0-9\-]+-(\d+\.\d+\.\d+(-[+\-.a-z0-9]+)?)\.tgz$/,
           ['name', null, 'org', null, 'version']
         ],
         firewall(registry, rules)

src/main/js/http/client.js

@@ -2,7 +2,7 @@ import http from 'node:http'
 import https from 'node:https'
 import {parse} from 'node:url'
 
-import { makeDeferred } from '../util.js'
+import {makeDeferred, normalizePath} from '../util.js'
 
 export const request = async (opts) => {
   const {url, method = 'GET', postData, pipe, followRedirects, timeout = 30_000} = opts
@@ -14,7 +14,7 @@ export const request = async (opts) => {
     hostname,
     port = isSecure ? 443 : 80,
     lib = isSecure ? https : http
-  } = parse(url)
+  } = parse(normalizePath(url))
 
   const {promise, resolve, reject} = makeDeferred()
 

src/main/js/mwares/proxy.js

@@ -6,6 +6,5 @@ export const proxy = (registry) => async (req, res, next) => {
   }
 
   const url = `${registry}${req.url}`
-
   await request({ url, method: req.method, pipe: {req, res}, followRedirects: true})
 }

src/test/js/index.js

@@ -11,6 +11,7 @@ const app = createApp([{
   ],
   firewall: {
     registry: 'https://registry.npmmirror.com',
+    base: '/registry',
     rules: [
       {
         "policy": "deny",
@@ -37,17 +38,17 @@ await app.start()
   ],
   [
     '404 if not found',
-    { url: 'http://localhost:3001/not-found/path/on/remote', method: 'GET'},
+    { url: 'http://localhost:3001/registry/not-found/path/on/remote', method: 'GET'},
     { statusCode: 404 }
   ],
   [
     'gets tarball if allowed',
-    { url: 'http://localhost:3001/@antongolub/git-root/-/git-root-1.5.6.tgz', method: 'GET'},
+    { url: 'http://localhost:3001/registry/@antongolub/git-root/-/git-root-1.5.6.tgz', method: 'GET'},
     { hash: 'uMs0P/SZUnoc+oF6E0VVPSnkXphOfg1GXRl+wnx/tElmLNPtNCuh2n7EVbSJU5hv73q96YK04bBVRQmS2p2Cjw==' }
   ],
   [
     'reads packument',
-    { url: 'http://localhost:3001/colors', method: 'GET'},
+    { url: 'http://localhost:3001/registry/colors', method: 'GET'},
     { statusCode: 200 }
   ],
 ].forEach(([name, {url, method}, expected]) => {