Make types public to improve testability

Author: antonioaversa

Taxes/Basics.cs

@@ -2,10 +2,11 @@
 using System.Collections.ObjectModel;
 using System.Globalization;
 using System.Text.RegularExpressions;
+using System.Text.Json.Serialization;
 
 namespace Taxes;
 
-public partial class Basics
+internal partial class Basics
 {
     public string ReportsDirectoryPath { get; }
 
@@ -192,3 +193,17 @@ public sealed class CountryWithholdingTaxes
 
     public sealed record EventsFiles(string FilePattern, string Broker);
 }
+
+[JsonSourceGenerationOptions(
+    WriteIndented = true,
+    AllowTrailingCommas = true,
+    PropertyNameCaseInsensitive = true,
+    ReadCommentHandling = JsonCommentHandling.Skip)]
+[JsonSerializable(typeof(Basics))]
+public partial class BasicsContext : JsonSerializerContext;
+
+public partial class Basics
+{
+    public static readonly Basics Default =
+        JsonSerializer.Deserialize<Basics>(
+// ... existing code ...

Taxes/CryptoEventsReader.cs

@@ -4,7 +4,7 @@
 
 namespace Taxes;
 
-class CryptoEventsReader(Basics basics)
+public class CryptoEventsReader(Basics basics)
 {
     // Unlike stocks, which are considered distinct assets, all cryptos, from a tax perspective, are considered a single asset.
     // When a stock is bought or sold, the tax office looks into what specific stock has been affected by the financial event, and tax
@@ -21,13 +21,13 @@ class CryptoEventsReader(Basics basics)
     // TRANSFER,Current,2022-06-25 13:29:03,2022-06-25 13:29:03,Exchanged to ZRX,1000.0000000000,ZRX,293.9067439000,298.3167439000,4.4100000000,EUR,COMPLETED,1000.0000000000
     // REWARD,Current,2022-06-25 13:29:03,2022-06-25 13:29:03,Exchanged to ZRX,1000.0000000000,ZRX,293.9067439000,298.3167439000,4.4100000000,EUR,COMPLETED,1000.0000000000
 
-    const string Type_Reset = "RESET";
-    const string Type_Transfer = "TRANSFER";
-    const string Type_Exchange = "EXCHANGE";
-    const string Type_Reward = "REWARD";
-    const string Product_Current = "Current";
-    const string Product_CryptoStaking = "Crypto Staking";
-    const string State_Completed = "COMPLETED";
+    private const string Type_Reset = "RESET";
+    private const string Type_Transfer = "TRANSFER";
+    private const string Type_Exchange = "EXCHANGE";
+    private const string Type_Reward = "REWARD";
+    private const string Product_Current = "Current";
+    private const string Product_CryptoStaking = "Crypto Staking";
+    private const string State_Completed = "COMPLETED";
 
     // Example of 2025 CSV format:
     // Symbol,Type,Quantity,Price,Value,Fees,Date
@@ -37,9 +37,9 @@ class CryptoEventsReader(Basics basics)
     // BTC,Sell,0.03053533,"EUR 63,551.31","EUR 1,940.56",EUR 19.21,"May 22, 2024, 3:30:49 PM"
     // ETH,Sell,0.1,"3,235.24 CHF",323.52 CHF,2.55 CHF,"Dec 1, 2024, 7:58:16 PM"
 
-    const string Type2025_Buy = "Buy";
-    const string Type2025_Sell = "Sell";
-    const string Type2025_Reset = "Reset";
+    private const string Type2025_Buy = "Buy";
+    private const string Type2025_Sell = "Sell";
+    private const string Type2025_Reset = "Reset";
 
     public Basics Basics => basics;
 

Taxes/CryptoPortfolioValues.cs

@@ -4,7 +4,7 @@
 
 namespace Taxes;
 
-class CryptoPortfolioValues
+public class CryptoPortfolioValues
 {
     private static CsvConfiguration CsvConfiguration(Basics basics) => 
         new(basics.DefaultCulture)

Taxes/DecimalExtensions.cs

@@ -1,6 +1,6 @@
 namespace Taxes;
 
-public static class DecimalExtensions
+internal static class DecimalExtensions
 {
     /// <summary>
     /// Shortcut to round a decimal via the Rounding method defined in the provided Basics 

Taxes/EnumerableExtensions.cs

@@ -1,6 +1,6 @@
 namespace Taxes;
 
-static class EnumerableExtensions
+internal static class EnumerableExtensions
 {
     public static IEnumerable<T> EnsureNonEmpty<T>(this IEnumerable<T> values)
     {

Taxes/Event.cs

@@ -11,7 +11,7 @@
 /// - Fees: fees of all shares in this event
 /// - Portfolio: all shares of all events, not just this event
 /// </summary>
-record Event(
+public record Event(
     /// <summary>
     /// The date and time at which the event occurred.
     /// It's mandatory for all types of events, even synthetic ones like Reset.

Taxes/EventType.cs

@@ -1,7 +1,7 @@
 namespace Taxes;
 
 /// <summary>
-/// The type of an event.
+/// The type of event.
 /// </summary>
 public enum EventType
 {

Taxes/EventsFileAndBroker.cs

@@ -1,3 +1,3 @@
 namespace Taxes;
 
-record EventsFileAndBroker(string FilePath, string Broker);
+public record EventsFileAndBroker(string FilePath, string Broker);

Taxes/FXRates.cs

@@ -38,7 +38,7 @@ public record FxRates(Basics Basics, Dictionary<string, Dictionary<DateTime, dec
         return result;
     }
 
-    static bool IsWeekend(DateTime date) => date.DayOfWeek is DayOfWeek.Saturday or DayOfWeek.Sunday;
+    private static bool IsWeekend(DateTime date) => date.DayOfWeek is DayOfWeek.Saturday or DayOfWeek.Sunday;
 
     internal sealed class DictionaryAlwaysReturning1 : IDictionary<DateTime, decimal>
     {

Taxes/FileUtils.cs

@@ -2,7 +2,7 @@
 
 namespace Taxes;
 
-public static class FileUtils
+internal static class FileUtils
 {
     public static string CalculateMD5Digest(string filePath)
     {