-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathmanager_test.go
More file actions
402 lines (347 loc) · 8.48 KB
/
manager_test.go
File metadata and controls
402 lines (347 loc) · 8.48 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
package swole
import (
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
"net/url"
"testing"
)
func TestRegisterExperiment(t *testing.T) {
tests := []struct {
name string
experiment Experiment
wantPanic bool
isDuplicate bool
}{
{
name: "Empty key",
experiment: Experiment{
Alternatives: Alternatives{
{
Name: "control",
},
{
Name: "variant",
},
},
},
wantPanic: true,
},
{
name: "Empty alternatives",
experiment: Experiment{
Key: "Test key",
},
wantPanic: true,
},
{
name: "Duplicate alternatives",
experiment: Experiment{
Key: "Test key",
Alternatives: Alternatives{
{
Name: "control",
Weight: 1,
},
{
Name: "control",
Weight: 2,
},
},
},
wantPanic: true,
},
{
name: "Duplicate experiment",
experiment: Experiment{
Key: "Test key",
Alternatives: Alternatives{
{
Name: "control",
},
{
Name: "variant",
},
},
},
wantPanic: true,
isDuplicate: true,
},
{
name: "Negative weights",
experiment: Experiment{
Key: "Test key",
Alternatives: Alternatives{
{
Name: "control",
Weight: -1,
},
{
Name: "variant",
},
},
},
wantPanic: true,
},
{
name: "Valid experiment",
experiment: Experiment{
Key: "Test key",
Alternatives: Alternatives{
{
Name: "control",
},
{
Name: "variant",
},
},
},
},
{name: "Valid experiment with weights",
experiment: Experiment{
Key: "Test key",
Alternatives: Alternatives{
{
Name: "control",
Weight: 10,
},
{
Name: "variant",
Weight: 20,
},
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
manager := NewExperimentManager()
if tt.isDuplicate {
manager.RegisterExperiment(tt.experiment)
}
if tt.wantPanic {
assertPanic(t, func() {
manager.RegisterExperiment(tt.experiment)
})
} else {
manager.RegisterExperiment(tt.experiment)
createdExperiment, found := manager.getExperiment(tt.experiment.Key)
if !found {
t.Error("Expected experiment to exist in memory but it wasn't found")
}
for i, alt := range createdExperiment.Alternatives {
if tt.experiment.Alternatives[i].Name != alt.Name {
t.Errorf("expected alternative to be %s got %s", tt.experiment.Alternatives[i].Name, alt.Name)
}
if alt.Weight == 0 {
t.Errorf("expected alternative to be not 0 got %d", alt.Weight)
}
// weight was provided
if tt.experiment.Alternatives[i].Weight != 0 {
if tt.experiment.Alternatives[i].Weight != alt.Weight {
t.Errorf("expected alternative to have weight %d got %d", tt.experiment.Alternatives[i].Weight, alt.Weight)
}
}
}
}
})
}
}
func TestStartExperiment(t *testing.T) {
t.Run("experiment not registered", func(t *testing.T) {
manager := NewExperimentManager()
w := httptest.NewRecorder()
r := httptest.NewRequest(http.MethodGet, "/", nil)
_, err := manager.StartExperiment("non_existent", w, r)
if err == nil {
t.Error("expected to error but did not")
}
})
t.Run("experiment start first time", func(t *testing.T) {
manager := NewExperimentManager()
w := httptest.NewRecorder()
r := httptest.NewRequest(http.MethodGet, "/", nil)
key := "experiment_key"
manager.RegisterExperiment(Experiment{
Key: key,
Alternatives: Alternatives{
{
Name: "control",
},
{
Name: "variant",
},
},
})
response, err := manager.StartExperiment(key, w, r)
if err != nil {
t.Errorf("expected not to error but got: %v", err)
}
if response.Alternative != "control" && response.Alternative != "variant" {
t.Errorf("expected alternative to be control or variant but got: %s", response.Alternative)
}
if !response.DidStart {
t.Error("expected DidStart to be true but got false")
}
if !response.DidStartFirstTime {
t.Error("expected DidStartFirstTime to be true but got false")
}
// cookieValue := getExperimentCookieValue(t, w)
// if cookieValue[key] != response.Alternative {
// t.Errorf("expected alternative to be: %s but got: %s", response.Alternative, cookieValue[key])
// }
// if len(cookieValue) != 1 {
// t.Errorf("expected to have only one experiment but got: %d", len(cookieValue))
// }
// manager.RegisterExperiment(Experiment{
// Key: "second_experiment",
// Alternatives: Alternatives{
// {
// Name: "control",
// },
// {
// Name: "variant",
// },
// },
// })
// r.AddCookie(getExperimentCookie(t, w))
// w = httptest.NewRecorder()
// manager.StartExperiment("second_experiment", w, r)
// cookieValue = getExperimentCookieValue(t, w)
// fmt.Printf("cookieVal %+v\n", cookieValue)
})
t.Run("Experiment was already started", func(t *testing.T) {
manager := NewExperimentManager()
w := httptest.NewRecorder()
r := httptest.NewRequest(http.MethodGet, "/", nil)
key := "experiment_key"
manager.RegisterExperiment(Experiment{
Key: key,
Alternatives: Alternatives{
{
Name: "control",
},
{
Name: "variant",
},
},
})
firstResponse, err := manager.StartExperiment(key, w, r)
fmt.Printf("Cookies are: %+v\n", w.Result().Cookies())
if err != nil {
t.Errorf("expected not to error but got: %v", err)
}
w2 := httptest.NewRecorder()
r2 := newRequestFromResponse(w)
response, err := manager.StartExperiment(key, w2, r2)
if err != nil {
t.Errorf("expected not to error but got: %v", err)
}
if response.Alternative != firstResponse.Alternative {
t.Errorf("expected alternative to be %s but got: %s", firstResponse.Alternative, response.Alternative)
}
if !response.DidStart {
t.Error("expected DidStart to be true but got false")
}
if response.DidStartFirstTime {
t.Error("expected DidStartFirstTime to be false but got true")
}
})
t.Run("Experiment with different name has already started", func(t *testing.T) {
manager := NewExperimentManager()
w := httptest.NewRecorder()
r := httptest.NewRequest(http.MethodGet, "/", nil)
key := "experiment_key"
manager.RegisterExperiment(Experiment{
Key: key,
Alternatives: Alternatives{
{
Name: "control",
},
{
Name: "variant",
},
},
})
_, err := manager.StartExperiment(key, w, r)
if err != nil {
t.Errorf("expected not to error but got: %v", err)
}
secondKey := "second_experiment"
manager.RegisterExperiment(Experiment{
Key: secondKey,
Alternatives: Alternatives{
{
Name: "control",
},
{
Name: "variant",
},
},
})
w2 := httptest.NewRecorder()
r2 := newRequestFromResponse(w)
response, err := manager.StartExperiment(secondKey, w2, r2)
if err != nil {
t.Errorf("expected not to error but got: %v", err)
}
if err != nil {
t.Errorf("expected not to error but got: %v", err)
}
if response.Alternative != "control" && response.Alternative != "variant" {
t.Errorf("expected alternative to be control or variant but got: %s", response.Alternative)
}
if !response.DidStart {
t.Error("expected DidStart to be true but got false")
}
if !response.DidStartFirstTime {
t.Error("expected DidStartFirstTime to be true but got false")
}
})
}
func assertPanic(t *testing.T, f func()) {
t.Helper()
defer func() {
if r := recover(); r == nil {
t.Errorf("expected to panic but did not")
}
}()
f()
}
func newRequestFromResponse(rr *httptest.ResponseRecorder) *http.Request {
r := httptest.NewRequest(http.MethodGet, "/", nil)
cookies := rr.Result().Cookies()
for _, c := range cookies {
r.AddCookie(c)
}
return r
}
func getExperimentCookieValue(t *testing.T, w *httptest.ResponseRecorder, cookieName string) map[string]string {
t.Helper()
cookie := getExperimentCookie(t, w, cookieName)
return parseValue(t, cookie)
}
func getExperimentCookie(t *testing.T, w *httptest.ResponseRecorder, cookieName string) *http.Cookie {
t.Helper()
res := http.Response{Header: w.Header()}
for _, c := range res.Cookies() {
if c.Name == cookieName {
return c
}
}
t.Fatal("could not find the cookie")
return nil
}
func parseValue(t *testing.T, cookie *http.Cookie) map[string]string {
var parsedVal map[string]string
unescapedValue, err := url.QueryUnescape(cookie.Value)
if err != nil {
t.Fatal(err)
}
err = json.Unmarshal([]byte(unescapedValue), &parsedVal)
if err != nil {
t.Fatal(err)
}
return parsedVal
}