Skip to content

Commit 7a28fbe

Browse files
committed
docs: clarify dark-mode vs Valentus roles and legacy names
Add Legacy names migration guide; stop recommending stacking the overlay on Valentus (already bundled); fix Default UI examples.
1 parent 2ad713e commit 7a28fbe

13 files changed

Lines changed: 138 additions & 24 deletions

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
node -e "const fs=require('fs');const p=JSON.parse(fs.readFileSync('package.json','utf8'));delete p.private;fs.writeFileSync('package.json',JSON.stringify(p,null,2)+'\n')"
104104
npm --version
105105
npm publish --access public
106-
npm deprecate antora-dark-theme@* "Renamed — use valentus-theme (bundled dark mode). See https://github.com/antora-supplemental/valentus-theme" || true
106+
npm deprecate antora-dark-theme@* "Split: use valentus-theme (chrome + dark) or antora-dark-mode (overlay only). See https://antora-supplemental.github.io/antora-dark-mode/antora-dark-mode/guide/legacy-names.html" || true
107107
# Trusted publisher on npmjs.com (package → Settings → Trusted publishing):
108108
# Provider: GitHub Actions
109109
# Organization/user: antora-supplemental

CHANGELOG.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ Entries below are in **chronological order** by date: prior release, then the **
1010

1111
== [Unreleased]
1212

13+
* *Docs:* Guide page xref:guide:legacy-names.adoc[Legacy names & migration] — `antora-dark-theme` → `valentus-theme` / `antora-dark-mode`, canonical org repos vs personal forks, Zulip correction blurb. Linked from Getting Started and Installation.
14+
* *Docs:* Clarify product roles — Valentus release bundle already includes dark mode; overlay / ui-module examples use Default UI (do not stack this package on Valentus `ui-bundle.zip`).
1315
* *CI:* Release workflow fixes (`v*.*.*` tag filter, `workflow_dispatch`, lockfile); npm publish via trusted publishing (OIDC) — no `NPM_TOKEN`.
1416

1517
== [1.3.1] - 2026-06-13

README.adoc

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,22 @@ If you'd like to see native dark mode support in Antora, please upvote the featu
4242

4343
Your support helps the Antora team prioritize this feature!
4444

45-
**Doc-site chrome** (mast, header layout, VCS icons) lives in link:https://github.com/antora-supplemental/valentus-theme[valentus-theme].
46-
Pair dark mode as overlay or ui-module on top of the *valentus* `ui.bundle` — not the other way around.
45+
**Full chrome + dark mode** (mast, header, layout, VCS icons, toggle) lives in link:https://github.com/antora-supplemental/valentus-theme[valentus-theme] — use that release `ui-bundle.zip` when you want the whole stack.
46+
This package is the *dark-mode-only* overlay for Default UI or other themes that do not already ship dark mode.
47+
Coming from the retired **`antora-dark-theme`** name? See xref:legacy-names.adoc[Legacy names & migration].
4748

4849
== Quick Start
4950

5051
=== Overlay on your theme bundle (recommended)
5152

52-
Reserve `ui.bundle` for your theme. Layer dark mode via one `supplemental_files` directory:
53+
Reserve `ui.bundle` for a theme that does *not* already include dark mode (Default UI, custom themes, etc.).
54+
Do **not** layer this overlay on the Valentus release bundle — Valentus already bundles dark mode.
5355

5456
[source,yaml]
5557
----
5658
ui:
5759
bundle:
58-
url: https://github.com/antora-supplemental/valentus-theme/releases/download/v2/ui-bundle.zip
60+
url: https://gitlab.com/antora/antora-ui-default/-/jobs/artifacts/HEAD/raw/build/ui-bundle.zip?job=bundle-stable
5961
snapshot: true
6062
supplemental_files: ./site/supplemental-ui # merge antora-dark-mode supplemental-ui here
6163
----

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22

33
Dark mode supplemental UI for Antora — overlay install or slot-based ui-module.
44

5-
**Does not occupy `ui.bundle`** when mixed with valentus or other themes. See [Installation](https://antora-supplemental.github.io/antora-dark-mode/antora-dark-mode/guide/installation.html).
5+
**Does not occupy `ui.bundle`** when mixed with another theme. See [Installation](https://antora-supplemental.github.io/antora-dark-mode/antora-dark-mode/guide/installation.html).
6+
7+
Want mast/header/layout chrome *plus* dark mode? Use **[valentus-theme](https://github.com/antora-supplemental/valentus-theme)** (release `ui-bundle.zip` already includes dark mode) — do not stack this overlay on Valentus.
8+
9+
Migrating from the retired **`antora-dark-theme`** package? See [Legacy names & migration](https://antora-supplemental.github.io/antora-dark-mode/antora-dark-mode/guide/legacy-names.html).
610

711
---
812

@@ -15,7 +19,7 @@ pnpm add -D antora-dark-mode
1519
```yaml
1620
ui:
1721
bundle:
18-
url: https://github.com/antora-supplemental/valentus-theme/releases/download/v2/ui-bundle.zip
22+
url: https://gitlab.com/antora/antora-ui-default/-/jobs/artifacts/HEAD/raw/build/ui-bundle.zip?job=bundle-stable
1923
snapshot: true
2024
supplemental_files: ./site/supplemental-ui # merge node_modules/antora-dark-mode/supplemental-ui
2125
```
@@ -42,6 +46,7 @@ Republishing to npm as **overlay transport** (not `ui.bundle` replacement). Same
4246
| Resource | URL |
4347
|----------|-----|
4448
| Install guide | [installation.adoc](docs/modules/guide/pages/installation.adoc) |
49+
| Legacy names | [legacy-names.adoc](docs/modules/guide/pages/legacy-names.adoc) |
4550
| UI modules | [ui-modules.adoc](docs/modules/guide/pages/ui-modules.adoc) |
4651
| Live demo | [antora-supplemental.github.io/antora-dark-mode](https://antora-supplemental.github.io/antora-dark-mode) |
4752
| Source | [github.com/antora-supplemental/antora-dark-mode](https://github.com/antora-supplemental/antora-dark-mode) |

docs/maintainers/antora-chat-corrections.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
Post these in [Antora Zulip](https://antora.zulipchat.com/) where older threads still reference `antora-dark-theme`.
44

5+
Published guide (preferred link for readers): [Legacy names & migration](https://antora-supplemental.github.io/antora-dark-mode/antora-dark-mode/guide/legacy-names.html) (`docs/modules/guide/pages/legacy-names.adoc`).
6+
57
---
68

79
## Short correction (reply to outdated install advice)

docs/maintainers/npm-republish-plan.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ After trusted publishing works, consider **Settings → Publishing access → Re
6464

6565
```powershell
6666
# After publish — deprecate legacy package name (if you own antora-dark-theme)
67-
npm deprecate antora-dark-theme@* "Renamed — use antora-dark-mode. See https://github.com/antora-supplemental/antora-dark-mode"
67+
npm deprecate antora-dark-theme@* "Split: use valentus-theme (chrome + dark) or antora-dark-mode (overlay only). See https://antora-supplemental.github.io/antora-dark-mode/antora-dark-mode/guide/legacy-names.html"
6868
```
6969

7070
`prepack` script runs sync + validate automatically.

docs/modules/guide/nav.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
.Documentation
22
* xref:index.adoc[Getting Started]
33
* xref:installation.adoc[Installation]
4+
* xref:legacy-names.adoc[Legacy names & migration]
45
* xref:ui-modules.adoc[UI Modules]
56
* xref:npm-distribution.adoc[npm distribution]
67
* xref:configuration.adoc[Configuration]

docs/modules/guide/pages/index.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ Dark mode toggle, FOUC prevention, and CSS overrides for the Antora Default UI.
66

77
For composed doc-site chrome (mast, header, layout), see link:https://github.com/antora-supplemental/valentus-theme[valentus-theme].
88

9+
Coming from the former **`antora-dark-theme`** package (or a personal fork of that name)? See xref:legacy-names.adoc[Legacy names & migration].
10+
911
== Install
1012

1113
See xref:installation.adoc[Installation], xref:ui-modules.adoc[UI Modules], and xref:npm-distribution.adoc[npm distribution].

docs/modules/guide/pages/installation.adoc

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@
33
:description: Install Antora dark mode as a supplemental overlay or composable UI module.
44

55
Dark mode is a *slipstream overlay* — it must **not** occupy `ui.bundle.url` when you mix it with another theme.
6-
Reserve `ui.bundle` for your theme (Default UI, valentus-theme, architexture-theme, a custom bundle, etc.).
6+
Reserve `ui.bundle` for your theme (Default UI, architexture-theme, a custom bundle, etc.).
7+
8+
IMPORTANT: link:https://github.com/antora-supplemental/valentus-theme[valentus-theme] already ships *bundled* dark mode in its release `ui-bundle.zip`.
9+
Do **not** layer this overlay on Valentus unless you are composing modules from scratch — use Valentus alone for the full chrome + dark stack.
10+
Coming from the retired **`antora-dark-theme`** package? See xref:legacy-names.adoc[Legacy names & migration].
711

812
* link:https://github.com/antora-supplemental/antora-dark-mode/releases[GitHub Releases]
913
* link:https://antora-supplemental.github.io/docs/[Antora Supplemental docs portal] (extensions registry)
@@ -15,12 +19,12 @@ Reserve `ui.bundle` for your theme (Default UI, valentus-theme, architexture-the
1519
| Path | When to use | `ui.bundle` owner
1620

1721
| xref:#overlay[Supplemental overlay] (recommended)
18-
| Any theme; one merged `supplemental_files` directory
19-
| Your theme or Default UI
22+
| Dark mode on Default UI or a theme that does *not* already include it
23+
| Your theme or Default UI (**not** Valentus release bundle)
2024

2125
| xref:ui-modules.adoc[UI module + orchestrator]
22-
| Theme chrome from valentus + dark mode without partial collisions
23-
| Your theme release bundle
26+
| Slot-based inject when the theme owns `head-meta` / `footer-scripts` partials
27+
| Your theme release bundle (compose; skip if using Valentus pre-merged zip)
2428

2529
| xref:#convenience-bundle[Convenience `ui-bundle.zip`]
2630
| Quick start on Default UI only — no other theme
@@ -51,7 +55,7 @@ cp -r node_modules/antora-dark-mode/supplemental-ui/* site/supplemental-ui/
5155
----
5256
ui:
5357
bundle:
54-
url: https://github.com/antora-supplemental/valentus-theme/releases/download/v2/ui-bundle.zip
58+
url: https://gitlab.com/antora/antora-ui-default/-/jobs/artifacts/HEAD/raw/build/ui-bundle.zip?job=bundle-stable
5559
snapshot: true
5660
supplemental_files: ./site/supplemental-ui
5761
----
Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,88 @@
1+
= Legacy names & migration
2+
:navtitle: Legacy names
3+
:description: Migrate from antora-dark-theme (and personal forks) to antora-dark-mode and valentus-theme.
4+
5+
[[migrate-from-antora-dark-theme]]
6+
== From `antora-dark-theme`
7+
8+
The monolithic **`antora-dark-theme`** package was split and renamed under the `antora-supplemental` organization.
9+
10+
[cols="2,3", options="header"]
11+
|===
12+
| Former | Use instead
13+
14+
| `antora-dark-theme` (npm / GitHub release bundle) as full site UI
15+
| link:https://github.com/antora-supplemental/valentus-theme[`valentus-theme`^] release `ui-bundle.zip` (chrome + **bundled dark mode**)
16+
17+
| Dark mode only on another theme / Default UI
18+
| **`antora-dark-mode`** — slipstream overlay (must **not** occupy `ui.bundle` when mixed with another theme)
19+
|===
20+
21+
=== Playbook: full stack
22+
23+
Replace:
24+
25+
[source,yaml]
26+
----
27+
ui:
28+
bundle:
29+
url: https://github.com/antora-supplemental/antora-dark-theme/releases/.../ui-bundle.zip
30+
----
31+
32+
With:
33+
34+
[source,yaml]
35+
----
36+
ui:
37+
bundle:
38+
url: https://github.com/antora-supplemental/valentus-theme/releases/download/v2/ui-bundle.zip
39+
snapshot: true
40+
----
41+
42+
Remove `antora-dark-theme` from `package.json` if present.
43+
Valentus install details: link:https://antora-supplemental.github.io/valentus-theme/[valentus-theme docs^].
44+
45+
=== Playbook: dark mode overlay only
46+
47+
Keep your theme (or Default UI) in `ui.bundle`, then layer dark mode via `supplemental_files` — see xref:installation.adoc[Installation].
48+
49+
[source,bash]
50+
----
51+
pnpm add -D antora-dark-mode
52+
----
53+
54+
== Canonical repositories (not personal forks)
55+
56+
| Role | Canonical home |
57+
|---|---|
58+
| Dark mode overlay | https://github.com/antora-supplemental/antora-dark-mode[`antora-supplemental/antora-dark-mode`^] |
59+
| Composed chrome + dark mode | https://github.com/antora-supplemental/valentus-theme[`antora-supplemental/valentus-theme`^] |
60+
| Org public GitHub config | https://github.com/antora-supplemental/.github[`antora-supplemental/.github`^] |
61+
| Org private GitHub config | https://github.com/antora-supplemental/.github-private[`antora-supplemental/.github-private`^] |
62+
63+
Personal forks of the old `antora-dark-theme` name (for example under a member account) are obsolete once history is contained in the org repos above.
64+
Do not publish or pin those forks as the install source.
65+
66+
Default UI dark-mode experiments that lived on a GitLab fork of `antora-ui-default` are **upstream proposals** (see open MRs on https://gitlab.com/antora/antora-ui-default[`antora/antora-ui-default`^]).
67+
Sites that need dark mode today should use this overlay or Valentus rather than waiting on Default UI merge.
68+
69+
== Zulip / community corrections
70+
71+
Short copy for threads that still say `antora-dark-theme`:
72+
73+
[source,text]
74+
----
75+
The monolithic antora-dark-theme package was split:
76+
- Full chrome + dark mode → valentus-theme (release ui-bundle.zip)
77+
- Dark mode overlay only → antora-dark-mode
78+
Docs: https://antora-supplemental.github.io/valentus-theme/
79+
----
80+
81+
Maintainer paste templates also live in `docs/maintainers/antora-chat-corrections.md`.
82+
83+
== See also
84+
85+
* xref:installation.adoc[Installation]
86+
* xref:npm-distribution.adoc[npm distribution]
87+
* link:https://antora-supplemental.github.io/docs/docs/theme-products.html[Theme products (org docs hub)^]
88+
* link:https://antora-supplemental.github.io/docs/docs/org-github-config.html[Org GitHub config (docs hub)^]

0 commit comments

Comments
 (0)