Skip to content

Commit 8455873

Browse files
committed
release: v1.0.7 — fix edit-breadcrumb Handlebars comment leak
{{! comments end at the first }}; nested {{> partial}} in the comment leaked text before the Edit control. Drop the header line. Changelog + changelog-details. Made-with: Cursor
1 parent 1824867 commit 8455873

4 files changed

Lines changed: 14 additions & 2 deletions

File tree

CHANGELOG.adoc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ and this project adheres to https://semver.org/spec/v2.0.0.html[Semantic Version
88

99
Entries below are in **chronological order** by date: prior release, then the **2026-03-04** org creation and repository move, then the next release.
1010

11+
== [1.0.7] - 2026-04-26
12+
13+
* *Bugfix:* `partials/edit-breadcrumb.hbs` — remove a `{{! … }}` line that embedded `{{> …}}` example syntax. Handlebars ends `{{!` comments at the first `}}`, so part of the comment leaked as visible text before the breadcrumb *Edit* control.
14+
15+
link:changelog-details/2026-04-26%20-%201.0.7%20edit-breadcrumb%20comment%20leak.adoc[Detailed notes — 2026-04-26]
16+
1117
== [1.0.6] - 2026-04-26
1218

1319
* *Release / tag:* The annotated Git tag `v1.0.5` had peeled to an older commit than the `package.json` “Release v1.0.5” commit; **1.0.6** is the corrected publish line. Push Git tag `v1.0.6` to run link:.github/workflows/release.yml[Release] (GitHub Release, `ui-bundle.zip`, npm when trusted publishing is configured).
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
= 1.0.7 — edit-breadcrumb Handlebars comment leak
2+
:description: Changelog detail for antora-dark-theme 1.0.7
3+
:navtitle: 1.0.7 edit-breadcrumb fix
4+
5+
The first line of `supplemental-ui/partials/edit-breadcrumb.hbs` was a maintainer comment using `{{! … }}` while illustrating partial inclusion with `{{> edit-breadcrumb}}`. The inner `}}` closed the comment early; the remainder rendered as literal text in the breadcrumb bar.
6+
7+
The partial now starts with the `{{#if …}}` block and no fragile header comment.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "antora-dark-theme",
3-
"version": "1.0.6",
3+
"version": "1.0.7",
44
"description": "Dark mode supplemental UI theme for Antora documentation sites",
55
"keywords": [
66
"antora",

supplemental-ui/partials/edit-breadcrumb.hbs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{{! Optional: include in breadcrumbs as {{> edit-breadcrumb}}. Prefer page.editUrl (https) so VCS icon logic matches; file: only when no edit URL. }}
21
{{#if (and page.editUrl (or env.FORCE_SHOW_EDIT_PAGE_LINK (not page.origin.private)))}}
32
<li class="adt-breadcrumb-edit" role="presentation">
43
<a class="adt-edit-inline-link" href="{{page.editUrl}}" title="Edit this page" aria-label="Edit this page">

0 commit comments

Comments
 (0)