fix(azure.ai.agents): ResolveAfterInit suggests azd provision when project endpoint is unset

After `azd ai agent init` with "Deploy new model(s) from the catalog",
the suggestion was wrongly:

  Next:  azd ai agent run  -- start the agent locally
         azd deploy        -- when ready to deploy to Azure

even though provision had not run yet and the user has no agent to run
against (AZURE_AI_PROJECT_ENDPOINT empty, no Bicep outputs populated).

Root cause
==========

ResolveAfterInit's decision tree branched only on MissingInfraVars
(derived from `${AZURE_*}` references in agent.yaml). The notetaking
sample's agent.yaml has no such references, so the list stayed empty
and the resolver fell through to the "Otherwise → azd ai agent run"
branch. The new-models path stores its outputs (project endpoint,
model deployments) as azd env vars that aren't templated into
agent.yaml until provision runs, so there was no signal in the
existing tree.

Fix
===

Add `!state.HasProjectEndpoint` as the first condition. The project
endpoint is the canonical "provision finished" marker — it is set by
`azd provision` as a Bicep output, or by `azd ai agent init` when the
user selects "Use existing project". When empty, provision hasn't run
yet and `azd provision` is the correct next step regardless of whether
agent.yaml directly references any AZURE_* variables.

Decision tree after the fix:

  !HasProjectEndpoint OR MissingInfraVars → azd provision
  MissingManualVars                       → azd env set <key> <val>...
  Otherwise                               → azd ai agent run

The MissingInfraVars branch is preserved for the post-provision
re-provision case (user adds a new ${AZURE_*} reference to agent.yaml
after the last provision run).

Affected call sites (no changes needed at the call sites)
=========================================================

  - `init.go:1608` — the user-reported bug; now suggests `azd provision`.
  - `doctor.go:243` — second production caller; the doctor only renders
    Next: when all checks pass, so this path is reached only after the
    user has fixed the AZURE_AI_PROJECT_ENDPOINT failure — at which
    point HasProjectEndpoint=true and the existing "run locally"
    branch fires correctly.

Tests
=====

resolver_test.go::TestResolveAfterInit updated:

  - happy-path test now uses `&State{HasProjectEndpoint: true}` —
    represents a truly post-provision state.
  - new subtest "project endpoint not yet set → provision" pins
    the new branch on a zero-value State (the user's repro).
  - existing infra-vars subtest now also sets HasProjectEndpoint=true
    so it specifically exercises the re-provision case.
  - new subtest "project endpoint missing wins over manual vars"
    confirms ordering — provision unblocks both infra outputs AND
    manual var resolution, so it must come first.

resolver_test.go::TestResolveAfterInit_ManualVarsCapAtThree updated
to set HasProjectEndpoint=true (otherwise it would now hit the new
provision branch instead of testing the manual-vars cap).

Pre-flight
==========

  - gofmt -s -w .                                   clean
  - go vet ./...                                    clean
  - go build ./...                                  clean
  - go test ./... -count=1                          all green
  - golangci-lint run ./internal/cmd/nextstep/...   0 issues
  - cspell on resolver.go                           0 issues

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Antriksh Jain

cli/azd/extensions/azure.ai.agents/internal/cmd/nextstep/resolver.go

@@ -33,8 +33,18 @@ const (
 // successful `azd ai agent init`. Pure function over *State.
 //
 // Decision tree:
-//   - MissingInfraVars   → `azd provision` (then "run `azd ai agent run` to
-//     start locally" tail line)
+//   - !HasProjectEndpoint OR MissingInfraVars → `azd provision`
+//     The project endpoint is the canonical "provision finished"
+//     marker — it is set by `azd provision` as a Bicep output, or by
+//     `azd ai agent init` when the user selects an existing Foundry
+//     project. When the endpoint is empty, provision has not yet
+//     populated the infra outputs (typical path: user selected
+//     "Deploy new models from the catalog" in init), so `azd
+//     provision` is the next step regardless of whether agent.yaml
+//     directly references any AZURE_* variables. MissingInfraVars is
+//     still consulted to cover the post-provision re-provision case
+//     (a new ${AZURE_*} reference was added to agent.yaml after the
+//     last provision run).
 //   - MissingManualVars  → one `azd env set <KEY> <value>` per missing var
 //     (up to maxManualVarLines)
 //   - Otherwise          → `azd ai agent run`
@@ -48,7 +58,7 @@ func ResolveAfterInit(state *State) []Suggestion {
 	out := make([]Suggestion, 0, 4)
 
 	switch {
-	case len(state.MissingInfraVars) > 0:
+	case !state.HasProjectEndpoint || len(state.MissingInfraVars) > 0:
 		out = append(out, Suggestion{
 			Command:     "azd provision",
 			Description: "set up your Foundry project, models, and connections",

cli/azd/extensions/azure.ai.agents/internal/cmd/nextstep/resolver_test.go

@@ -22,25 +22,43 @@ func TestResolveAfterInit(t *testing.T) {
 		wantTrailing      string
 	}{
 		{
-			name:           "happy path → run locally",
-			state:          &State{},
+			name:           "happy path (provisioned) → run locally",
+			state:          &State{HasProjectEndpoint: true},
 			wantPrimaryHas: "azd ai agent run",
 			wantTrailing:   "azd deploy",
 		},
 		{
-			name:           "infra vars missing → provision",
-			state:          &State{MissingInfraVars: []string{"AZURE_AI_FOO"}},
+			name:           "project endpoint not yet set → provision",
+			state:          &State{},
+			wantPrimaryHas: "azd provision",
+			wantTrailing:   "azd deploy",
+		},
+		{
+			name: "infra vars missing post-provision → provision (re-provision)",
+			state: &State{
+				HasProjectEndpoint: true,
+				MissingInfraVars:   []string{"AZURE_AI_FOO"},
+			},
 			wantPrimaryHas: "azd provision",
 			wantTrailing:   "azd deploy",
 		},
 		{
 			name: "manual vars missing → up to 3 env set lines, sorted",
 			state: &State{
-				MissingManualVars: []string{"DELTA", "ALPHA", "ECHO", "BRAVO"},
+				HasProjectEndpoint: true,
+				MissingManualVars:  []string{"DELTA", "ALPHA", "ECHO", "BRAVO"},
 			},
 			wantManualVarKeys: []string{"ALPHA", "BRAVO", "DELTA"},
 			wantTrailing:      "azd deploy",
 		},
+		{
+			name: "project endpoint missing wins over manual vars (provision unblocks both)",
+			state: &State{
+				MissingManualVars: []string{"USER_API_KEY"},
+			},
+			wantPrimaryHas: "azd provision",
+			wantTrailing:   "azd deploy",
+		},
 	}
 
 	for _, tt := range tests {
@@ -73,7 +91,10 @@ func TestResolveAfterInit(t *testing.T) {
 func TestResolveAfterInit_ManualVarsCapAtThree(t *testing.T) {
 	t.Parallel()
 
-	state := &State{MissingManualVars: []string{"V1", "V2", "V3", "V4", "V5"}}
+	state := &State{
+		HasProjectEndpoint: true,
+		MissingManualVars:  []string{"V1", "V2", "V3", "V4", "V5"},
+	}
 	out := ResolveAfterInit(state)
 	// 3 manual + 1 trailing.
 	require.Len(t, out, 4)