Skip to content

Commit 0605e8d

Browse files
author
lkn
committed
fix: review fix
1 parent ecf0efd commit 0605e8d

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

src/ava.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,10 @@ export class AVA extends EventEmitter {
268268
async visualize(analysisResult: AnalysisResponse): Promise<VisualizeResponse | null> {
269269
const { data, query } = analysisResult;
270270

271+
if (!hasData(data)) {
272+
return null;
273+
}
274+
271275
try {
272276
// Format analysis data info from the analysis result data
273277
const analysisDataInfoStr = Array.isArray(data)
@@ -282,7 +286,7 @@ export class AVA extends EventEmitter {
282286
detail: chartType ?? 'No visualization needed',
283287
});
284288

285-
if (!chartType || !hasData(data)) {
289+
if (!chartType) {
286290
return null;
287291
}
288292

src/events.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,13 @@ export class EventEmitter {
1212
}
1313

1414
off(event: string, handler: Handler): this {
15-
this._events.get(event)?.delete(handler);
15+
const handlers = this._events.get(event);
16+
if (handlers) {
17+
handlers.delete(handler);
18+
if (handlers.size === 0) {
19+
this._events.delete(event);
20+
}
21+
}
1622
return this;
1723
}
1824

0 commit comments

Comments
 (0)