diff --git a/.changeset/heavy-berries-greet.md b/.changeset/heavy-berries-greet.md new file mode 100644 index 0000000000..d0876cbe8c --- /dev/null +++ b/.changeset/heavy-berries-greet.md @@ -0,0 +1,5 @@ +--- +'@antv/g-lite': patch +--- + +use nullish coalescing in createVec3 diff --git a/packages/g-lite/src/utils/math.ts b/packages/g-lite/src/utils/math.ts index 8ae710c76d..e7cfd1f75f 100644 --- a/packages/g-lite/src/utils/math.ts +++ b/packages/g-lite/src/utils/math.ts @@ -28,8 +28,8 @@ export function createVec3( } return clone - ? vec3.fromValues(x[0], x[1] || y, x[2] || z) - : vec3.set($vec3, x[0], x[1] || y, x[2] || z); + ? vec3.fromValues(x[0], x[1] ?? y, x[2] ?? z) + : vec3.set($vec3, x[0], x[1] ?? y, x[2] ?? z); } const DEG_RAD = Math.PI / 180; @@ -155,9 +155,9 @@ function getEulerFromMat4(out: vec3, m: mat4) { */ export function getEuler(out: vec3, quat: quat | mat4): vec3 { if (quat.length === 16) { - return getEulerFromMat4(out, quat as mat4); + return getEulerFromMat4(out, quat); } - return getEulerFromQuat(out, quat as quat); + return getEulerFromQuat(out, quat); } export function fromRotationTranslationScale(