fix: label transfrom remain #6781
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moayuisuda
commented
Apr 15, 2025
src/api/runtime.ts
Outdated
| // @fixme The cancel render is not marked, which will cause additional rendered event. | ||
| // @ref src/runtime/render.ts | ||
| /** | ||
| * @fixme Trailing render WILL NOT invoke AFTER_RENDER, only main render will invoke AFTER_RENDER. |
There was a problem hiding this comment.
这里是另一个bug，我先注释记录下
moayuisuda
force-pushed
the
fix/transform-remain
branch
from
feb1516 to
8ff381e
Compare
|
单测看看，对照下～ |
|
这个改动到的快照太多了（因为很多svg都会加上visibility属性），我尝试看看有无啥另外的方案不改动这么多单测的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
#6780
当原来 label 有 overlapHide 时，会把 label 的 visibility 置为 hidden
当更新节点，将 overlapHide 去除时，因为新生成的 label 的属性里没有 visibility 这个 key，会导致这里也不会更新节点的 visibility