Commit 312d6e9
authored
[proto] Remove redundant RPC GetLastCommittedBlockNumber() (hyperledger#155)
#### Type of change
- Improvement (improvement to code, performance, etc)
#### Description
- Remove redundant RPC in the coordinator:
`GetLastCommittedBlockNumber()` - It was already covered by
`GetNextExpectedBlockNumber()`
- Remove unnecessary stream check in `GetNextExpectedBlockNumber()` -
The sidecar verifies this anyway before calling this method
- Align API with VC - Replaced `GetLastCommittedBlockNumber()` with
`GetNextExpectedBlockNumber()`
- Adjust relevant tests
#### Related issues
- resolves hyperledger#48
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>1 parent fdf5de5 commit 312d6e9
23 files changed
Lines changed: 328 additions & 481 deletions
File tree
- api
- protoblocktx
- protocoordinatorservice
- protovcservice
- integration
- runner
- test
- loadgen/adapters
- mock
- service
- coordinator
- sidecar
- vc
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | 97 | | |
102 | 98 | | |
103 | 99 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments