Anvil App Server v1.2

Changes:

- Users service supports two-factor authentication
- URLMedia fetch fixes
- PDF rendering fix for apps with dependencies
- Doc updates
- OAuth fixes (MS and Google authentication)
- Stricter bytes/str enforcement in BlobMedia construction
- Downlink is more robust about cleaning up subprocesses

Based-on: anvil 96b13c0b30d2acdab28a6e9e1ac02a49de06bc4d

Author: Anvil Authors

README.md

@@ -278,7 +278,7 @@ Port for outbound SMTP server (see `smtp-host`).
 
 #### smtp-encryption
 
-Enable TLS for connecting to outbound SMTP server (see `smtp-host`).
+Enable TLS for connecting to outbound SMTP server (see `smtp-host`). Takes "starttls" or "ssl" as a string value.
 
 #### smtp-username
 

client/js/lib/skulpt-stdlib.js

@@ -13,6 +13,16 @@ module.exports = function(appOrigin, uncaughtExceptions) {
 
     let ByteString = Sk.__future__.python3 ? Sk.builtin.bytes : Sk.builtin.str;
 
+    let arrayBufferToStr = arrayBuffer => {
+        let binary = "";
+        var bytes = new Uint8Array(arrayBuffer);
+        var length = bytes.byteLength;
+        for (var i = 0; i < length; i++) {
+            binary += String.fromCharCode(bytes[i]);
+        }
+        return binary;
+    }
+
     /**
     id: anvil_module
     docs_url: /docs/client/python#the-anvil-module
@@ -164,7 +174,13 @@ module.exports = function(appOrigin, uncaughtExceptions) {
                 let leafName = ps[ps.length-1];
                 // Yes, sysmodules is indexed with JS strings.
                 // No, this makes no sense.
-                let pyFormMod = Sk.sysmodules.mp$subscript(window.anvilAppMainPackage + "." + formName);
+                let pyFormMod;
+                try {
+                    pyFormMod = Sk.sysmodules.mp$subscript(window.anvilAppMainPackage + "." + formName);
+                } catch (e) {
+                    pyFormMod = Sk.sysmodules.mp$subscript(formName);
+                }
+
 
                 var formConstructor = pyFormMod.$d[leafName];
 
@@ -299,7 +315,7 @@ module.exports = function(appOrigin, uncaughtExceptions) {
                     $.ajax({
                       url: self._url,
                       type: "GET",
-                      dataType: "text",
+                      dataType: "binary",
                       processData: false,
                     }).then(function(r,ts,xhr) {
                         window.setLoading(false);
@@ -326,7 +342,11 @@ module.exports = function(appOrigin, uncaughtExceptions) {
 
         $loc["get_bytes"] = new Sk.builtin.func(function(self) {
             return new PyDefUtils.suspensionPromise(function(resolve, reject) {
-                doFetch(self).then(function(r) { resolve(new ByteString(r.data)); }, reject);
+                doFetch(self).then(function(r) {
+                    return r.data.arrayBuffer();
+                }, reject).then(function(arrayBuffer) {
+                    resolve(new ByteString(arrayBufferToStr(arrayBuffer)))
+                });
             });
         });
 
@@ -407,13 +427,7 @@ module.exports = function(appOrigin, uncaughtExceptions) {
                         fr.readAsBinaryString(self._data);
                     } else {
                         fr.onloadend = function() { 
-                            let binary = "";
-                            var bytes = new Uint8Array(fr.result);
-                            var length = bytes.byteLength;
-                            for (var i = 0; i < length; i++) {
-                                binary += String.fromCharCode(bytes[i]);
-                            }
-                            resolve(new ByteString(binary));
+                            resolve(new ByteString(arrayBufferToStr(fr.result)));
                         };
                         fr.readAsArrayBuffer(self._data);
                     }

client/js/lib/skulpt.min.js

@@ -228,7 +228,7 @@ function loadApp(app, appId, appOrigin, preloadModules) {
 
     var accumulatingPrints = null;
 
-    var sendLog = function(details) { console.log(logDetails); };
+    var sendLog = function(details) { console.log(details); };
 
     var stdout = function(text, fromServer) {
         if (text != "\n") {
@@ -301,7 +301,7 @@ function loadApp(app, appId, appOrigin, preloadModules) {
                 }
             };
 
-            if (errorObj instanceof serverModuleAndLog.pyMod["SessionExpiredError"]) {
+            if (serverModuleAndLog && errorObj instanceof serverModuleAndLog.pyMod["SessionExpiredError"]) {
                 $("#session-expired-modal button.refresh").off("click").on("click", function() {
                     document.location.href = window.anvilAppOrigin + "/" + (window.anvilParams.accessKey || '');
                 });

client/js/lib/skulpt.min.js.map

@@ -6,7 +6,7 @@ module.exports = {
 
   // We want to generate two bundles. One for runner. one for its Service Worker
   entry: {
-    runner: ['babel-polyfill', './runner.js'],
+    runner: ['./runner.js'],
     sw: ['babel-polyfill',  './sw.js'],
   },
 

client/js/lib/unorm.js

@@ -254,11 +254,14 @@ <h4 class="modal-title">Kerberos Authentication</h4>
   <script src="{{cdn-origin}}/runtime/node_modules/moment/min/moment.min.js?buildTime=0" crossorigin></script>
   <script src="{{cdn-origin}}/runtime/node_modules/moment-timezone/builds/moment-timezone-with-data-2012-2022.min.js?buildTime=0" crossorigin></script>
   <script src="{{cdn-origin}}/runtime/js/lib/daterangepicker.js?buildTime=0" crossorigin></script>
+  <script src="{{cdn-origin}}/runtime/js/lib/b64.js?buildTime=0" crossorigin></script>
   <script src="{{cdn-origin}}/runtime/js/lib/bootstrap-notify.min.js?buildTime=0" crossorigin></script>
 
   <script src="{{cdn-origin}}/runtime/node_modules/js-yaml/dist/js-yaml.min.js?buildTime=0" crossorigin></script>
   <script src="{{cdn-origin}}/runtime/js/lib/mutationobserver.min.js?buildTime=0" crossorigin></script>
 
+  <script src="{{cdn-origin}}/runtime/node_modules/core-js/client/core.min.js?buildTime=0" crossorigin></script>
+
   <script src="https://www.youtube.com/iframe_api"></script>
   <script>
     function gm_authFailure(e) { window.googleMapsAuthFailure = true; };
@@ -267,6 +270,7 @@ <h4 class="modal-title">Kerberos Authentication</h4>
 
   <script src="https://checkout.stripe.com/checkout.js"></script>
 
+  <script src='{{cdn-origin}}/runtime/js/lib/unorm.js?buildTime=0' crossorigin></script>
 
   <script src='{{cdn-origin}}/runtime/js/lib/skulpt.min.js?buildTime=0' crossorigin></script>
   <script src='{{cdn-origin}}/runtime/js/lib/skulpt-stdlib.js?buildTime=0' crossorigin></script>

client/js/modules/anvil.js

@@ -6,14 +6,14 @@
     <meta name="viewport" content="width=device-width, initial-scale=1">
     <title>Email confirmed</title>
 
-    <link rel="stylesheet" href="{{cdn-origin}}/runtime/core/css/bootstrap.css?buildTime=0">
-    <link rel="stylesheet" href="{{cdn-origin}}/runtime/core/css/bootstrap-theme.min.css?buildTime=0">
+    <link rel="stylesheet" href="{{cdn-origin}}/runtime/css/bootstrap.css?buildTime=0">
+    <link rel="stylesheet" href="{{cdn-origin}}/runtime/css/bootstrap-theme.min.css?buildTime=0">
 
-    <script src="{{cdn-origin}}/runtime/core/node_modules/html5-boilerplate/dist/js/vendor/modernizr-3.8.0.min.js?buildTime=0"></script>
+    <script src="{{cdn-origin}}/runtime/node_modules/html5-boilerplate/dist/js/vendor/modernizr-3.8.0.min.js?buildTime=0"></script>
 
 
-    <script src="{{cdn-origin}}/runtime/core/node_modules/jquery/dist/jquery.min.js?buildTime=0"></script>
-    <script src="{{cdn-origin}}/runtime/core/node_modules/bootstrap/dist/js/bootstrap.min.js?buildTime=0"></script>
+    <script src="{{cdn-origin}}/runtime/node_modules/jquery/dist/jquery.min.js?buildTime=0"></script>
+    <script src="{{cdn-origin}}/runtime/node_modules/bootstrap/dist/js/bootstrap.min.js?buildTime=0"></script>
 
 </head>
 <body>