GO-5904: Fix null format for type of layout note without icon

Author: jmetrikat

src/utils/icon.ts

@@ -11,15 +11,6 @@ import { colorToHex, iconWidth } from "./constant";
  * @returns The base64 data URI or Raycast Icon.
  */
 export async function getIconWithFallback(icon: ObjectIcon, layout: string, type?: RawType): Promise<Image.ImageLike> {
-  // notes always show grey type icon
-  if (layout === ObjectLayout.Note) {
-    if (type?.icon.format === IconFormat.Icon && type?.icon.name) {
-      return getCustomTypeIcon(type.icon.name, "grey");
-    } else {
-      console.warn("note type has no icon", type);
-    }
-  }
-
   if (icon && icon.format) {
     // type built-in icons
     if (icon.format === IconFormat.Icon && icon.name) {
@@ -32,10 +23,6 @@ export async function getIconWithFallback(icon: ObjectIcon, layout: string, type
       if (fileSource) {
         return { source: fileSource, mask: getMaskForObject(icon.file, layout) };
       }
-      if (type?.icon.format === IconFormat.Icon && type?.icon.name) {
-        return getCustomTypeIcon(type.icon.name, "grey");
-      }
-      return await fallbackToLayout(layout);
     }
 
     // regular emoji
@@ -46,7 +33,7 @@ export async function getIconWithFallback(icon: ObjectIcon, layout: string, type
 
   // fallback to grey version of type built-in icon
   if (type?.icon && type.icon.format === IconFormat.Icon && type.icon.name) {
-    return getCustomTypeIcon(type?.icon.name, "grey");
+    return getCustomTypeIcon(type.icon.name, "grey");
   }
 
   // fallback to layout