Refactor createObject, createProperty, createTag, and createType functions to remove null handling

Author: jmetrikat

src/api/objects/createObject.ts

@@ -2,18 +2,13 @@ import { mapObject } from "../../mappers/objects";
 import { CreateObjectRequest, RawSpaceObject, SpaceObject } from "../../models";
 import { apiEndpoints, apiFetch } from "../../utils";
 
-export async function createObject(
-  spaceId: string,
-  request: CreateObjectRequest,
-): Promise<{ object: SpaceObject | null }> {
+export async function createObject(spaceId: string, request: CreateObjectRequest): Promise<{ object: SpaceObject }> {
   const { url, method } = apiEndpoints.createObject(spaceId);
 
   const response = await apiFetch<{ object: RawSpaceObject }>(url, {
     method: method,
     body: JSON.stringify(request),
   });
 
-  return {
-    object: response ? await mapObject(response.payload.object) : null,
-  };
+  return { object: await mapObject(response.payload.object) };
 }

src/api/properties/createProperty.ts

@@ -2,18 +2,13 @@ import { mapProperty } from "../../mappers/properties";
 import { CreatePropertyRequest, Property, RawProperty } from "../../models";
 import { apiEndpoints, apiFetch } from "../../utils";
 
-export async function createProperty(
-  spaceId: string,
-  request: CreatePropertyRequest,
-): Promise<{ property: Property | null }> {
+export async function createProperty(spaceId: string, request: CreatePropertyRequest): Promise<{ property: Property }> {
   const { url, method } = apiEndpoints.createProperty(spaceId);
 
   const response = await apiFetch<{ property: RawProperty }>(url, {
     method: method,
     body: JSON.stringify(request),
   });
 
-  return {
-    property: response ? mapProperty(response.payload.property) : null,
-  };
+  return { property: mapProperty(response.payload.property) };
 }

src/api/tags/createTag.ts

@@ -2,19 +2,13 @@ import { mapTag } from "../../mappers/properties";
 import { CreateTagRequest, RawTag, Tag } from "../../models";
 import { apiEndpoints, apiFetch } from "../../utils";
 
-export async function createTag(
-  spaceId: string,
-  propertyId: string,
-  request: CreateTagRequest,
-): Promise<{ tag: Tag | null }> {
+export async function createTag(spaceId: string, propertyId: string, request: CreateTagRequest): Promise<{ tag: Tag }> {
   const { url, method } = apiEndpoints.createTag(spaceId, propertyId);
 
   const response = await apiFetch<{ tag: RawTag }>(url, {
     method: method,
     body: JSON.stringify(request),
   });
 
-  return {
-    tag: response ? mapTag(response.payload.tag) : null,
-  };
+  return { tag: mapTag(response.payload.tag) };
 }

src/api/types/createType.ts

@@ -2,15 +2,13 @@ import { mapType } from "../../mappers/types";
 import { CreateTypeRequest, RawType, Type } from "../../models";
 import { apiEndpoints, apiFetch } from "../../utils";
 
-export async function createType(spaceId: string, request: CreateTypeRequest): Promise<{ type: Type | null }> {
+export async function createType(spaceId: string, request: CreateTypeRequest): Promise<{ type: Type }> {
   const { url, method } = apiEndpoints.createType(spaceId);
 
   const response = await apiFetch<{ type: RawType }>(url, {
     method: method,
     body: JSON.stringify(request),
   });
 
-  return {
-    type: response ? await mapType(response.payload.type) : null,
-  };
+  return { type: await mapType(response.payload.type) };
 }

src/components/CreateForm/CreateObjectForm.tsx

@@ -185,7 +185,7 @@ export function CreateObjectForm({ draftValues, enableDrafts }: CreateObjectForm
 
         const response = await createObject(selectedSpaceId, request);
 
-        if (response.object?.id) {
+        if (response.object.id) {
           if (selectedListId) {
             const request: AddObjectsToListRequest = { objects: [response.object.id] };
             await addObjectsToList(selectedSpaceId, selectedListId, request);