Fix empty type filter returning all objects in search despite layout-specific view

Author: jmetrikat

src/hooks/useGlobalSearch.ts

@@ -5,9 +5,17 @@ import { globalSearch } from "../api";
 import { SortDirection } from "../models";
 import { apiLimit } from "../utils";
 
-export function useGlobalSearch(query: string, types: string[]) {
+export function useGlobalSearch(query: string, types: string[], config?: { execute?: boolean }) {
+  const shouldExecute = config?.execute !== false;
   const { data, error, isLoading, mutate, pagination } = useCachedPromise(
-    (query: string, types: string[]) => async (options: { page: number }) => {
+    (query: string, types: string[], shouldExecute: boolean) => async (options: { page: number }) => {
+      if (!shouldExecute) {
+        return {
+          data: [],
+          hasMore: false,
+        };
+      }
+
       const offset = options.page * apiLimit;
       const sortPreference = getPreferenceValues().sort;
       const sortDirection = sortPreference === "name" ? SortDirection.Ascending : SortDirection.Descending;
@@ -22,7 +30,7 @@ export function useGlobalSearch(query: string, types: string[]) {
         hasMore: response.pagination.has_more,
       };
     },
-    [query, types],
+    [query, types, shouldExecute],
     {
       keepPreviousData: true,
     },

src/search-anytype.tsx

@@ -38,6 +38,7 @@ function Search() {
   const { objects, objectsError, isLoadingObjects, mutateObjects, objectsPagination } = useGlobalSearch(
     searchText,
     types,
+    { execute: currentView === ViewType.objects || types.length > 0 }, // only execute search when viewing all objects or when specific types selected
   );
   const { spaces, spacesError, isLoadingSpaces } = useSpaces();
   const { pinnedObjects, pinnedObjectsError, isLoadingPinnedObjects, mutatePinnedObjects } = usePinnedObjects(