Skip to content

Commit 54bf5b9

Browse files
author
Dean Wampler
committed
Bug fix: If the organization is specified, it has to be used in the FROM clause for Dockerfile-academy-all
1 parent 842c990 commit 54bf5b9

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ $(IMAGE_NAMES:%=%-image): echo
4848
docker build \
4949
$(DOCKER_TAGS:%=--tag $(ORGANIZATION)/${@:%-image=%}:%) \
5050
--build-arg VERSION=$(ACADEMY_VERSION) \
51+
--build-arg ORGANIZATION=$(ORGANIZATION) \
5152
-f $(DOCKERFILE_BASE)-${@:%-image=%} stage
5253

5354
stage-base: stage/academy-base

docker/Dockerfile-academy-all

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
FROM deanwampler/academy-base:latest
1+
ARG VERSION
2+
ARG ORGANIZATION
3+
FROM ${ORGANIZATION}/academy-base:${VERSION}
24
ARG VERSION
35
LABEL maintainer="Anyscale Academy <[email protected]>"
46

5-
ADD academy-all/academy-$VERSION /root/academy-$VERSION
6-
RUN ls -al /root/academy-$VERSION
7+
ADD academy-all/academy-${VERSION} /root/academy-${VERSION}
8+
RUN ls -al /root/academy-${VERSION}

docker/Dockerfile-academy-base

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
FROM anyscale/ray:0.8.7
22
ARG VERSION
3+
ARG ORGANIZATION
34
LABEL maintainer="Anyscale Academy <[email protected]>"
45

56
SHELL ["/bin/bash", "-o", "pipefail", "-c"]

0 commit comments

Comments
 (0)