Skip to content

Do not assume the user uses bash when installing #4670

@ThatOneCalculator

Description

@ThatOneCalculator

Problem

When installing the Solana CLI (via sh -c "$(curl -sSfL https://release.anza.xyz/stable/install)"), the program assumes the user is using bash, and appends export PATH="$HOME/.local/share/solana/install/active_release/bin:$PATH" to .bash_profile even if the user does not use bash. (Found this issue while installing using the fish shell).

Proposed Solution

  1. If the current $SHELL isn't bash, simply tell the user to add the path manually
  2. If the current $SHELL is another common shell like fish, zsh, etc, properly add the path to the relevant config file, PREFERABLY asking the user if they would like their config file automatically edited (this may be undesired behavior!)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions