Use test_assert for debug_asserts that are used for failing tests #5318
Conversation
In an effort to test in release mode Fixes: anza-xyz#5316
There was a problem hiding this comment.
I'm personally not a fan of wholesale replacing debug_assert! with a test-only assert. Maybe the test should be rewritten? Or maybe the functions being tested need to be rewritten/refactored for testability.
Also, we don't test with release builds, so I'm not in agreement with the problem statement of this PR.
sounds reasonable. I can rewrite those tests to remove debug_asserts.
that was the argument(that we should be testing in release builds as well) raised in https://discord.com/channels/428295358100013066/838890116386521088 |
|
#5361 handles the div better. |
Merged 5361 today |
|
If these are tests, what is wrong with just using |
Problem
These tests fail in release mode because they use debug_assert to trigger a panic.
Summary of Changes
Add a test_assert that only triggers in test and not dependent on debug/release.
Fixes: #5316