cli: off-by-one in dynamic-port-range validation

[adborden]

Problem

CHANGELOG refers to the minimum port range as 25 ports in agave v3.0.0.

If you run the validator with --dynamic-port-range 8000-8024 (25 ports), it fails with the error:

error: Invalid value for '--dynamic-port-range <MIN_PORT-MAX_PORT>': Port range is too small. Try --dynamic-port-range 8000-8025

The validation is testing for 26 minimum ports, not 25.

Proposed Solution

Use MINIMUM_VALIDATOR_PORT_RANGE_WIDTH - 1 in the validation check and in the error message in port_range_validation.

[Ansh-699]

#7910

fixed

[buildr-daemon]

@alexpyattaev @lijunwangs
#9641 -> new pr, I have add fix for this based on the above discussion in #7910

[alexpyattaev]

AFAIK the original reason for this was that in rust (and many other contexts) the ranges do not include the upper bound. This issue was raised before though, so we should consider a more sensible design. Stay tuned.