forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 878
Open
Description
Problem
Published solana-faucet versions 3.1.x on crates.io have an incorrect version pin for solana-instruction:
- Current:
solana-instruction = "=3.0.0" - Expected:
solana-instruction = "=3.1.0"
This causes dependency resolution failures for downstream projects that use other solana crates from the 3.1.x release (which depend on solana-instruction ~3.1).
Error Example
error: failed to select a version for `solana-instruction`.
... required by package `solana-faucet v3.1.5`
... which satisfies dependency `solana-faucet = "=3.1.5"` of package `solana-rpc v3.1.5`
versions that meet the requirements `=3.0.0` are: 3.0.0
previously selected package `solana-instruction v3.1.0`
... which satisfies dependency `solana-instruction = "~3.1"` of package `downstream-crate`
Root Cause
- PR update solana-system-interface, cost model regression test #9341 accidentally relaxed version pins in
solana-faucet - PR pin solana-instruction version for solana-cli, solana-faucet and solana-keygen #9797 fixed this on
masterby re-pinning to=3.1.0 - The fix has not been backported to the
v3.1branch
Current state on v3.1 branch:
# faucet/Cargo.toml on origin/v3.1
solana-instruction = "=3.0.0" # Should be "=3.1.0"Requested Action
- Backport PR pin solana-instruction version for solana-cli, solana-faucet and solana-keygen #9797 to the
v3.1branch - Publish a new
solana-faucetversion (3.1.7+) with the correct pin
Affected Crates
Per PR #9797, the same issue affects:
solana-clisolana-faucetsolana-keygen
All three should have the backport applied.
References
- Fix PR (on master): pin solana-instruction version for solana-cli, solana-faucet and solana-keygen #9797
- PR that introduced the regression: update solana-system-interface, cost model regression test #9341
Metadata
Metadata
Assignees
Labels
No labels