errors: Lop off the string part of BorshIoError (#974)

#### Problem

The `BorshIoError` variant of `InstructionError` was changed from a string to a unit variant in the Rust SDK in [this PR](anza-xyz/solana-sdk#12), but the change hasn't been reflected in Kit yet.

#### Summary of changes

Change the `BorshIoError` variant to lop off any string that comes back for compatibility with old and new errors emitted by the runtime.

Add the new variant to the RPC error type list.

Author: joncinque

.changeset/moody-masks-drum.md

@@ -0,0 +1,6 @@
+---
+'@solana/rpc-types': major
+'@solana/errors': major
+---
+
+`BorshIoErrors` from the RPC no longer contain an `encodedData` property. This property used to hold the underlying error from the serialization library used on the server. This message was always subject to changes in the version of that library, or changes in the choice of library itself. New versions of the server no longer throw the underlying error, so for consistency it has been removed everywhere in Kit.

packages/errors/src/__tests__/instruction-error-test.ts

@@ -51,6 +51,7 @@ const EXPECTED_ERROR_CODES = [
     ['ProgramFailedToCompile', 4615042],
     ['Immutable', 4615043],
     ['IncorrectAuthority', 4615044],
+    ['BorshIoError', 4615045],
     ['AccountNotRentExempt', 4615046],
     ['InvalidAccountOwner', 4615047],
     ['ArithmeticOverflow', 4615048],
@@ -95,11 +96,10 @@ describe('getSolanaErrorFromInstructionError', () => {
             }),
         );
     });
-    it('produces the correct `SolanaError` for a `BorshIoError` error', () => {
+    it('produces the correct `SolanaError` for a `BorshIoError` error (pre SDK 3.0 newtype style)', () => {
         const error = getSolanaErrorFromInstructionError(123, { BorshIoError: 'abc' });
         expect(error).toEqual(
             new SolanaError(SOLANA_ERROR__INSTRUCTION_ERROR__BORSH_IO_ERROR, {
-                encodedData: 'abc',
                 index: 123,
             }),
         );

packages/errors/src/context.ts

@@ -395,7 +395,6 @@ export type SolanaErrorContext = DefaultUnspecifiedErrorContextToUndefined<
             variant: number;
         };
         [SOLANA_ERROR__INSTRUCTION_ERROR__BORSH_IO_ERROR]: {
-            encodedData: string;
             index: number;
         };
         [SOLANA_ERROR__INSTRUCTION_ERROR__CUSTOM]: {

packages/errors/src/instruction-error.ts

@@ -1,8 +1,4 @@
-import {
-    SOLANA_ERROR__INSTRUCTION_ERROR__BORSH_IO_ERROR,
-    SOLANA_ERROR__INSTRUCTION_ERROR__CUSTOM,
-    SOLANA_ERROR__INSTRUCTION_ERROR__UNKNOWN,
-} from './codes';
+import { SOLANA_ERROR__INSTRUCTION_ERROR__CUSTOM, SOLANA_ERROR__INSTRUCTION_ERROR__UNKNOWN } from './codes';
 import { SolanaError } from './error';
 import { getSolanaErrorFromRpcError } from './rpc-enum-errors';
 
@@ -89,11 +85,6 @@ export function getSolanaErrorFromInstructionError(
                         code: Number(rpcErrorContext as bigint | number),
                         index: numberIndex,
                     };
-                } else if (errorCode === SOLANA_ERROR__INSTRUCTION_ERROR__BORSH_IO_ERROR) {
-                    return {
-                        encodedData: rpcErrorContext as string,
-                        index: numberIndex,
-                    };
                 }
                 return { index: numberIndex };
             },

packages/rpc-types/src/transaction-error.ts

@@ -10,6 +10,7 @@ type InstructionError =
     | 'AccountNotExecutable'
     | 'AccountNotRentExempt'
     | 'ArithmeticOverflow'
+    | 'BorshIoError' // SDKv3 has a fieldless `BorshIoError`
     | 'BuiltinProgramsMustConsumeComputeUnits'
     | 'CallDepth'
     | 'ComputationalBudgetExceeded'
@@ -54,7 +55,6 @@ type InstructionError =
     | 'UninitializedAccount'
     | 'UnsupportedProgramId'
     | 'UnsupportedSysvar'
-    | { BorshIoError: string }
     | { Custom: CustomProgramError };
 
 type InstructionIndex = number;