[SOL] Add v4 CPU type #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
approved these changes
Apr 18, 2025
LucasSte
merged commit 606bad0
into
anza-xyz:solana-rustc/19.1-2024-12-03
18 checks passed
| @@ -439,6 +440,8 @@ static const ArchDefinitionEntry g_elf_arch_entries[] = { | |||
| 0xFFFFFFFFu, 0xFFFFFFFFu}, // sbfv2 | |||
| {ArchSpec::eCore_sbfv3, llvm::ELF::EM_SBF, ArchSpec::eSBFSubType_sbfv3, | |||
| 0xFFFFFFFFu, 0xFFFFFFFFu}, // sbfv3 | |||
| {ArchSpec::eCore_sbfv4, llvm::ELF::EM_SBF, ArchSpec::eSBFSubType_sbfv4, | |||
| 0xFFFFFFFFu, 0xFFFFFFFFu}, // sbfv3 | |||
There was a problem hiding this comment.
I guess the comment should have been // sbfv4, shouldn't it?
There was a problem hiding this comment.
Should just remove these comments altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the v4 CPU type for the SBF target. It includes a
abi-v2target feature to be surfaced to Rust as a specific target feature for conditional compilation.A follow-up PR will create the
sbpfv4-solana-solanatarget triple.