CI: hack check (#125)

Author: buffalojoec

.github/workflows/main.yml

@@ -47,6 +47,26 @@ jobs:
       - name: Run clippy
         run: make clippy
 
+  check_features:
+    name: Check Features
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/cache@v4
+        with:
+          path: |
+            ~/.cargo/registry
+            ~/.cargo/git
+          key: cargo-hack-${{ hashFiles('**/Cargo.lock') }}
+          restore-keys: |
+            cargo-hack-
+      - uses: dtolnay/rust-toolchain@stable
+      - uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-hack
+      - name: Check all feature combinations
+        run: make check-features
+
   cargo_build_test:
     name: Cargo Build and Test
     runs-on: ubuntu-latest

Makefile

@@ -1,7 +1,8 @@
 NIGHTLY_TOOLCHAIN := nightly-2024-11-22
 SOLANA_VERSION := 2.2.0
 
-.PHONY: audit build-test-programs prepublish publish format format-check clippy test nightly-version solana-version
+.PHONY: audit build-test-programs prepublish publish format format-check \
+	clippy test check-features all-checks nightly-version solana-version
 
 # Print the nightly toolchain version for CI
 nightly-version:
@@ -38,6 +39,7 @@ prepublish:
 	@$(MAKE) build-test-programs
 	@$(MAKE) format-check
 	@$(MAKE) clippy
+	@$(MAKE) check-features
 	@$(MAKE) test
 
 # Publish crates in order
@@ -76,6 +78,19 @@ format-check:
 clippy:
 	@cargo +$(NIGHTLY_TOOLCHAIN) clippy --all --all-features --all-targets -- -D warnings
 
+# Check all feature combinations with cargo-hack
+check-features:
+	@cargo hack check --feature-powerset --no-dev-deps
+
 # Run tests
 test:
-	@cargo test --all-features
+	@cargo test --all-features
+
+# Run all checks in sequence
+all-checks:
+	@echo "Running all checks..."
+	@$(MAKE) format-check
+	@$(MAKE) clippy
+	@$(MAKE) check-features
+	@$(MAKE) test
+	@echo "All checks passed!"

harness/Cargo.toml

@@ -23,7 +23,10 @@ fuzz-fd = [
     "dep:mollusk-svm-fuzz-fixture-firedancer",
     "dep:mollusk-svm-fuzz-fs",
 ]
-serde = ["dep:serde"]
+serde = [
+    "dep:serde",
+    "mollusk-svm-result/serde",
+]
 
 [dependencies]
 agave-feature-set = { workspace = true }

result/Cargo.toml

@@ -21,4 +21,4 @@ solana-rent = { workspace = true }
 [features]
 default = []
 fuzz = ["dep:mollusk-svm-fuzz-fixture"]
-serde = ["dep:serde"]
+serde = ["dep:serde", "solana-pubkey/serde"]

result/src/fuzz.rs

@@ -2,7 +2,6 @@
 
 use crate::types::{InstructionResult, ProgramResult};
 
-#[cfg(feature = "fuzz")]
 impl From<&InstructionResult> for mollusk_svm_fuzz_fixture::effects::Effects {
     fn from(input: &InstructionResult) -> Self {
         let compute_units_consumed = input.compute_units_consumed;
@@ -27,7 +26,6 @@ impl From<&InstructionResult> for mollusk_svm_fuzz_fixture::effects::Effects {
     }
 }
 
-#[cfg(feature = "fuzz")]
 impl From<&mollusk_svm_fuzz_fixture::effects::Effects> for InstructionResult {
     fn from(input: &mollusk_svm_fuzz_fixture::effects::Effects) -> Self {
         use solana_instruction::error::InstructionError;

result/src/lib.rs

@@ -31,6 +31,7 @@
 pub mod check;
 pub mod compare;
 pub mod config;
+#[cfg(feature = "fuzz")]
 pub mod fuzz;
 pub mod types;