Feat: Add debug/copy derives and enable missing debug/copy lint (#228)

* Add debug/copy derives and enable missing debug/copy lint

* Update sdk/pinocchio/src/sysvars/rent.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/entrypoint/mod.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/instruction.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/clock.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/fees.rs

* Update sdk/pinocchio/src/sysvars/fees.rs

* Update sdk/pinocchio/src/sysvars/instructions.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/instructions.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/instructions.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/clock.rs

* Fix syntax error in Instructions struct derive macro

---------

Co-authored-by: Fernando Otero <[email protected]>

Author: stegaBOB

Cargo.lock

@@ -18,7 +18,7 @@ pub const MAX_PERMITTED_DATA_INCREASE: usize = 1_024 * 10;
 
 /// Represents masks for borrow state of an account.
 #[repr(u8)]
-#[derive(Clone, Copy)]
+#[derive(Clone, Copy, Debug)]
 pub enum BorrowState {
     /// Mask to check whether an account is already borrowed.
     ///
@@ -112,7 +112,7 @@ pub(crate) struct Account {
 /// used to track borrows of the account data and lamports, given that an
 /// account can be "shared" across multiple `AccountInfo` instances.
 #[repr(C)]
-#[derive(Clone, PartialEq, Eq)]
+#[derive(Clone, Copy, PartialEq, Eq, Debug)]
 pub struct AccountInfo {
     /// Raw (pointer to) account data.
     ///
@@ -643,6 +643,7 @@ const LAMPORTS_BORROW_SHIFT: u8 = 4;
 const DATA_BORROW_SHIFT: u8 = 0;
 
 /// Reference to account data or lamports with checked borrow rules.
+#[derive(Debug)]
 pub struct Ref<'a, T: ?Sized> {
     value: NonNull<T>,
     state: NonNull<u8>,
@@ -714,6 +715,7 @@ const LAMPORTS_MUTABLE_BORROW_BITMASK: u8 = 0b_1000_0000;
 const DATA_MUTABLE_BORROW_BITMASK: u8 = 0b_0000_1000;
 
 /// Mutable reference to account data or lamports with checked borrow rules.
+#[derive(Debug)]
 pub struct RefMut<'a, T: ?Sized> {
     value: NonNull<T>,
     state: NonNull<u8>,

sdk/pinocchio/src/account_info.rs

@@ -515,6 +515,7 @@ pub fn get_return_data() -> Option<ReturnData> {
 }
 
 /// Struct to hold the return data from an invoked program.
+#[derive(Debug)]
 pub struct ReturnData {
     /// Program that most recently set the return data.
     program_id: Pubkey,

sdk/pinocchio/src/cpi.rs

@@ -100,6 +100,7 @@ macro_rules! lazy_program_entrypoint {
 ///
 /// This is a wrapper around the input buffer that provides methods to read the accounts
 /// and instruction data. It is used by the lazy entrypoint to access the input data on demand.
+#[derive(Debug)]
 pub struct InstructionContext {
     /// Pointer to the runtime input buffer to read from.
     ///
@@ -276,6 +277,7 @@ impl InstructionContext {
 }
 
 /// Wrapper type around an [`AccountInfo`] that may be a duplicate.
+#[derive(Debug, Copy, Clone)]
 pub enum MaybeAccount {
     /// An [`AccountInfo`] that is not a duplicate.
     Account(AccountInfo),

sdk/pinocchio/src/entrypoint/lazy.rs

@@ -668,6 +668,7 @@ mod alloc {
 
 #[cfg(not(feature = "std"))]
 /// An allocator that does not allocate memory.
+#[derive(Clone, Copy, Debug)]
 pub struct NoAllocator;
 
 #[cfg(not(feature = "std"))]

sdk/pinocchio/src/entrypoint/mod.rs

@@ -37,7 +37,7 @@ pub struct ProcessedSiblingInstruction {
 /// This struct contains the same information as an [`AccountInfo`], but has
 /// the memory layout as expected by `sol_invoke_signed_c` syscall.
 #[repr(C)]
-#[derive(Clone)]
+#[derive(Clone, Copy, Debug)]
 pub struct Account<'a> {
     // Public key of the account.
     key: *const Pubkey,

sdk/pinocchio/src/instruction.rs

@@ -217,7 +217,7 @@
 //! ```ignore
 //! cargo build-sbf --features bpf-entrypoint
 //! ```
-
+#![warn(missing_copy_implementations, missing_debug_implementations)]
 #![no_std]
 
 #[cfg(feature = "std")]

sdk/pinocchio/src/lib.rs

@@ -6,7 +6,7 @@
 //! <https://github.com/anza-xyz/solana-sdk/blob/master/program-error/src/lib.rs>
 
 /// Reasons the program may fail.
-#[derive(Clone, Debug, Eq, PartialEq)]
+#[derive(Clone, Copy, Debug, Eq, PartialEq)]
 pub enum ProgramError {
     /// Allows on-chain programs to implement program-specific error types and see them returned
     /// by the Solana runtime. A program-specific error may be any type that is represented as

sdk/pinocchio/src/program_error.rs

@@ -33,7 +33,7 @@ pub type UnixTimestamp = i64;
 ///
 /// All members of `Clock` start from 0 upon network boot.
 #[repr(C)]
-#[derive(Copy, Clone)]
+#[derive(Clone, Copy, Debug)]
 pub struct Clock {
     /// The current `Slot`.
     pub slot: Slot,

sdk/pinocchio/src/sysvars/clock.rs

@@ -22,7 +22,7 @@ impl FeeCalculator {
 }
 
 /// Governs the fee rate for the cluster
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Copy)]
 pub struct FeeRateGovernor {
     /// The current cost of a signature
     pub lamports_per_signature: u64,
@@ -74,7 +74,7 @@ impl FeeRateGovernor {
 }
 
 /// Fees sysvar
-#[derive(Debug)]
+#[derive(Copy, Clone, Debug)]
 pub struct Fees {
     /// Fee calculator for processing transactions
     pub fee_calculator: FeeCalculator,