system: Add create account helper #282
Conversation
febo
force-pushed
the
febo/create-account-helper
branch
from
4c01fc7 to
4b87477
Compare
febo
force-pushed
the
febo/create-account-helper
branch
from
4b87477 to
05f74a9
Compare
programs/system/src/lib.rs
Outdated
| to: account, | ||
| lamports: required_lamports, | ||
| } | ||
| .invoke()?; |
There was a problem hiding this comment.
Should we make this .invoke_signed(signers)?; to support the case a PDA acts as the funding account for the transfer?
There was a problem hiding this comment.
Yeah, that is a good point. It would only work for PDAs used as signers (i.e., owned by the system program), but it is a good idea to support this scenario.
Made the change on 1466eda and updated the docs.
| Rent::get()?.minimum_balance(space) | ||
| }; | ||
|
|
||
| if account.lamports() == 0 { |
There was a problem hiding this comment.
what do you think about using hints from pinocchio::hint module?
i expect account is not exist, in the majority of cases
| if account.lamports() == 0 { | |
| if likely(account.lamports() == 0) { |
There was a problem hiding this comment.
what do you think about using hints from
pinocchio::hintmodule?i expect account is not exist, in the majority of cases
It made no difference in my tests. Also, I had a look at the asm and it seems the compiler is doing the right thing already. Did you notice a difference?
There was a problem hiding this comment.
the same for the lib (i didn't test it in the real app).
As a part of library it compiles in the expected instructions.
Just wanted to make extra sure this logic won't be miscompiled in the large program.
There was a problem hiding this comment.
I wrote a small program and there was no difference. I think we can leave it as it is and revisit later if we see that there is a change in behaviour.
febo
force-pushed
the
febo/create-account-helper
branch
from
49fc5db to
1466eda
Compare
Problem
Creating accounts funded by a payer account is a common operation. In most cases, the logic needs to be replicated in different programs.
Solution
Add a helper to create accounts. The helper supports creating both PDA and non-PDA accounts.