Skip to content

Commit 40218b9

Browse files
authored
fee-calculator: Remove solana-logger dev-dependency (#405)
Remove the dependency and the couple info!() statements from unit tests since they would no longer print without a logger enabled
1 parent 8bf304a commit 40218b9

File tree

3 files changed

+1
-17
lines changed

3 files changed

+1
-17
lines changed

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fee-calculator/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,4 @@ solana-frozen-abi-macro = { workspace = true, optional = true }
2727

2828
[dev-dependencies]
2929
solana-clock = { workspace = true }
30-
solana-logger = { workspace = true }
3130
static_assertions = { workspace = true }

fee-calculator/src/lib.rs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,6 @@ mod tests {
193193

194194
#[test]
195195
fn test_fee_rate_governor_derived_default() {
196-
solana_logger::setup();
197-
198196
let f0 = FeeRateGovernor::default();
199197
assert_eq!(
200198
f0.target_signatures_per_slot,
@@ -223,8 +221,6 @@ mod tests {
223221

224222
#[test]
225223
fn test_fee_rate_governor_derived_adjust() {
226-
solana_logger::setup();
227-
228224
let mut f = FeeRateGovernor {
229225
target_lamports_per_signature: 100,
230226
target_signatures_per_slot: 100,
@@ -236,9 +232,7 @@ mod tests {
236232
let mut count = 0;
237233
loop {
238234
let last_lamports_per_signature = f.lamports_per_signature;
239-
240235
f = FeeRateGovernor::new_derived(&f, u64::MAX);
241-
info!("[up] f.lamports_per_signature={}", f.lamports_per_signature);
242236

243237
// some maximum target reached
244238
if f.lamports_per_signature == last_lamports_per_signature {
@@ -255,11 +249,6 @@ mod tests {
255249
let last_lamports_per_signature = f.lamports_per_signature;
256250
f = FeeRateGovernor::new_derived(&f, 0);
257251

258-
info!(
259-
"[down] f.lamports_per_signature={}",
260-
f.lamports_per_signature
261-
);
262-
263252
// some minimum target reached
264253
if f.lamports_per_signature == last_lamports_per_signature {
265254
break;
@@ -274,10 +263,7 @@ mod tests {
274263
let mut count = 0;
275264
while f.lamports_per_signature != f.target_lamports_per_signature {
276265
f = FeeRateGovernor::new_derived(&f, f.target_signatures_per_slot);
277-
info!(
278-
"[target] f.lamports_per_signature={}",
279-
f.lamports_per_signature
280-
);
266+
281267
// shouldn't take more than 100 steps to get to target
282268
assert!(count < 100);
283269
count += 1;

0 commit comments

Comments
 (0)