Bump Rust to 1.88, nightly to 2025-06-29 (#210)

#### Problem

Rust has been upgrading, but not the version used in the sdk repo. Also,
with the upcoming breaking changes to the sdk, it's a good time to bump
the rust edition to 2024, but we should upgrade to the newest Rust
first.

#### Summary of changes

Bump the version in rust-toolchain.toml and scripts/rust-version.sh,
then fix any issues reported.

Author: joncinque

account-info/src/lib.rs

@@ -106,25 +106,25 @@ impl<'a> AccountInfo<'a> {
         Ok(self.try_borrow_data()?.is_empty())
     }
 
-    pub fn try_borrow_lamports(&self) -> Result<Ref<&mut u64>, ProgramError> {
+    pub fn try_borrow_lamports(&self) -> Result<Ref<'_, &mut u64>, ProgramError> {
         self.lamports
             .try_borrow()
             .map_err(|_| ProgramError::AccountBorrowFailed)
     }
 
-    pub fn try_borrow_mut_lamports(&self) -> Result<RefMut<&'a mut u64>, ProgramError> {
+    pub fn try_borrow_mut_lamports(&self) -> Result<RefMut<'_, &'a mut u64>, ProgramError> {
         self.lamports
             .try_borrow_mut()
             .map_err(|_| ProgramError::AccountBorrowFailed)
     }
 
-    pub fn try_borrow_data(&self) -> Result<Ref<&mut [u8]>, ProgramError> {
+    pub fn try_borrow_data(&self) -> Result<Ref<'_, &mut [u8]>, ProgramError> {
         self.data
             .try_borrow()
             .map_err(|_| ProgramError::AccountBorrowFailed)
     }
 
-    pub fn try_borrow_mut_data(&self) -> Result<RefMut<&'a mut [u8]>, ProgramError> {
+    pub fn try_borrow_mut_data(&self) -> Result<RefMut<'_, &'a mut [u8]>, ProgramError> {
         self.data
             .try_borrow_mut()
             .map_err(|_| ProgramError::AccountBorrowFailed)

epoch-rewards-hasher/src/lib.rs

@@ -123,11 +123,7 @@ mod tests {
                 // size is same or 1 less
                 assert!(
                     len == expected_len_of_partition || len + 1 == expected_len_of_partition,
-                    "{}, {}, {}, {}",
-                    expected_len_of_partition,
-                    len,
-                    partition,
-                    partitions
+                    "{expected_len_of_partition}, {len}, {partition}, {partitions}",
                 );
             }
         }

hard-forks/src/lib.rs

@@ -29,7 +29,7 @@ impl HardForks {
     }
 
     // Returns a sorted-by-slot iterator over the registered hark forks
-    pub fn iter(&self) -> std::slice::Iter<(u64, usize)> {
+    pub fn iter(&self) -> std::slice::Iter<'_, (u64, usize)> {
         self.hard_forks.iter()
     }
 

instructions-sysvar/src/lib.rs

@@ -326,7 +326,7 @@ mod tests {
         is_writable: bool,
     }
 
-    fn make_borrowed_instruction(params: &MakeInstructionParams) -> BorrowedInstruction {
+    fn make_borrowed_instruction(params: &MakeInstructionParams) -> BorrowedInstruction<'_> {
         let MakeInstructionParams {
             program_id,
             account_key,

keypair/src/signable.rs

@@ -17,7 +17,7 @@ pub trait Signable {
     }
 
     fn pubkey(&self) -> Pubkey;
-    fn signable_data(&self) -> Cow<[u8]>;
+    fn signable_data(&self) -> Cow<'_, [u8]>;
     fn get_signature(&self) -> Signature;
     fn set_signature(&mut self, signature: Signature);
 }

message/src/compiled_keys.rs

@@ -35,8 +35,7 @@ impl fmt::Display for CompileError {
                 f.write_str("address lookup table index overflowed during compilation")
             }
             CompileError::UnknownInstructionKey(key) => f.write_fmt(format_args!(
-                "encountered unknown account key `{0}` during instruction compilation",
-                key,
+                "encountered unknown account key `{key}` during instruction compilation",
             )),
         }
     }

message/src/sanitized.rs

@@ -68,7 +68,7 @@ impl LegacyMessage<'_> {
     }
 
     /// Returns the full list of account keys.
-    pub fn account_keys(&self) -> AccountKeys {
+    pub fn account_keys(&self) -> AccountKeys<'_> {
         AccountKeys::new(&self.message.account_keys, None)
     }
 
@@ -197,7 +197,7 @@ impl SanitizedMessage {
     }
 
     /// Returns the list of account keys that are loaded for this message.
-    pub fn account_keys(&self) -> AccountKeys {
+    pub fn account_keys(&self) -> AccountKeys<'_> {
         match self {
             Self::Legacy(message) => message.account_keys(),
             Self::V0(message) => message.account_keys(),
@@ -285,7 +285,7 @@ impl SanitizedMessage {
     }
 
     /// Decompile message instructions without cloning account keys
-    pub fn decompile_instructions(&self) -> Vec<BorrowedInstruction> {
+    pub fn decompile_instructions(&self) -> Vec<BorrowedInstruction<'_>> {
         let account_keys = self.account_keys();
         self.program_instructions_iter()
             .map(|(program_id, instruction)| {

message/src/versions/v0/loaded.rs

@@ -98,7 +98,7 @@ impl<'a> LoadedMessage<'a> {
     }
 
     /// Returns the full list of static and dynamic account keys that are loaded for this message.
-    pub fn account_keys(&self) -> AccountKeys {
+    pub fn account_keys(&self) -> AccountKeys<'_> {
         AccountKeys::new(&self.message.account_keys, Some(&self.loaded_addresses))
     }
 

native-token/src/lib.rs

@@ -38,7 +38,7 @@ pub fn sol_str_to_lamports(sol_str: &str) -> Option<u64> {
         let lamports = if lamports.is_empty() {
             0
         } else {
-            format!("{:0<9}", lamports)[..SOL_DECIMALS].parse().ok()?
+            format!("{lamports:0<9}")[..SOL_DECIMALS].parse().ok()?
         };
         LAMPORTS_PER_SOL
             .checked_mul(sol)

program/src/program.rs

@@ -244,7 +244,7 @@ pub fn check_type_assumptions() {
         assert_eq!(offset_of!(AccountInfo, data), 16);
         let data_ptr = (account_info_addr + 16) as *const Rc<RefCell<&mut [u8]>>;
         unsafe {
-            assert_eq!((*(*data_ptr).as_ptr())[..], data[..]);
+            assert_eq!((&(*(*data_ptr).as_ptr()))[..], data[..]);
         }
 
         // owner