Skip to content

Commit 1cb338c

Browse files
committed
Improve CMakeLists.txt to better support PKG-Config, and a version bump.
1 parent 752d664 commit 1cb338c

File tree

4 files changed

+27
-21
lines changed

4 files changed

+27
-21
lines changed

CMakeLists.txt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,28 +84,29 @@ endif()
8484
# Install
8585
################################################################################################
8686

87-
set(PKG_CONFIG_INCLUDEDIR "\${prefix}/include")
88-
set(PKG_CONFIG_LIBDIR "\${prefix}/lib")
89-
set(PKG_CONFIG_LIBS "-L\${libdir} -lopenjph")
90-
set(PKG_CONFIG_CFLAGS "-I\${includedir}")
91-
9287
include(GNUInstallDirs)
9388
install(TARGETS openjph
9489
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
9590
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
9691
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR})
9792

9893
install(DIRECTORY src/core/common/
99-
DESTINATION include/openjph
94+
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/openjph
10095
FILES_MATCHING
10196
PATTERN "*.h")
10297

10398
install(FILES "${CMAKE_BINARY_DIR}/${PROJECT_NAME}.pc"
10499
DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
105100

101+
set(PKG_CONFIG_INCLUDEDIR "\${prefix}/${CMAKE_INSTALL_INCLUDEDIR}")
102+
set(PKG_CONFIG_LIBDIR "\${prefix}/${CMAKE_INSTALL_LIBDIR}")
103+
set(PKG_CONFIG_LIBS "-L\${libdir} -lopenjph")
104+
set(PKG_CONFIG_CFLAGS "-I\${includedir}")
105+
106106
configure_file(
107107
"${CMAKE_CURRENT_SOURCE_DIR}/src/pkg-config.pc.cmake"
108108
"${CMAKE_BINARY_DIR}/${PROJECT_NAME}.pc"
109+
@ONLY
109110
)
110111

111112
################################################################################################

src/apps/CMakeLists.txt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,15 @@ if(OJPH_BUILD_EXECUTABLES)
3434
endif()
3535
############################################################
3636

37-
## Change folders
38-
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../bin)
39-
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../bin)
40-
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../lib)
41-
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../bin)
42-
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../bin)
43-
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../lib)
37+
## change folders but only for Microsoft
38+
if(MSVC)
39+
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../bin)
40+
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../bin)
41+
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../lib)
42+
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../bin)
43+
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../bin)
44+
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../lib)
45+
endif()
4446

4547
## Build executables
4648
add_subdirectory(ojph_expand)

src/core/CMakeLists.txt

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11

2-
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../bin)
3-
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../bin)
4-
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../lib)
5-
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../bin)
6-
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../bin)
7-
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../lib)
2+
## change folders but only for Microsoft
3+
if (MSVC)
4+
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../bin)
5+
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../bin)
6+
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/../lib)
7+
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../bin)
8+
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../bin)
9+
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/../lib)
10+
endif()
811

912
include_directories(common)
1013

@@ -89,7 +92,7 @@ else()
8992
set_source_files_properties(transform/ojph_transform_avx2.cpp PROPERTIES COMPILE_FLAGS -mavx2)
9093
endif()
9194

92-
if (WIN32)
95+
if (MSVC)
9396
set(OJPH_LIB_NAME_STRING "openjph.${OPENJPH_VERSION_MAJOR}.${OPENJPH_VERSION_MINOR}")
9497
set_target_properties(openjph
9598
PROPERTIES

src/core/common/ojph_version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@
3535

3636
#define OPENJPH_VERSION_MAJOR 0
3737
#define OPENJPH_VERSION_MINOR 10
38-
#define OPENJPH_VERSION_PATCH 2
38+
#define OPENJPH_VERSION_PATCH 3

0 commit comments

Comments
 (0)