OpenJPH 0.24.1 build error with Apple clang 12

[ashugg]

Hi Aous, unfortunately the changes to ojph_mem.h in commit 3c89901 for #198 make OpenJPH 0.24.1 unbuildable on one of my computers.

I see from the discussion in issue 198 that the changes bring significant performance improvements on the Linux platform and looking at the changes to ojph_mem.h I'm thinking that it should be a simple matter of a bit more ifdef logic in the namespace ojph {} section to fix the issue for me.

The platform in question is Mac OS X 10.15, which is very old I know, and out of vendor support - so I don't expect you to make any effort to fix it. I'll try to figure it out myself and send you a PR.

On my second oldest platform, OpenJPH 0.24.1 builds without issue.

Fails to build:
Apple clang version 12.0.0 (clang-1200.0.32.29)

Successfully builds:
Apple clang version 14.0.0 (clang-1400.0.29.202)

Andrew

[aous72]

Hi Andrew,

Thank you for putting this in.

Is this related to PR #214?
In my testing on Macbook Air 2012, which I happen to have, running 10.15.7 with clang 12, there were no issues, but I understand earlier versions may have issues.

I am planning to put the offending aligned_alloc in their own ".c" file and declare them extern "C" functions, compiling the ".c" file using -std=c11; this should solve the problem.
I am going on leave soon, and this may take some time.

Please let me know if I am wrong.

Kind regards,
Aous.