Skip to content

Commit c2df3ba

Browse files
authored
Added log.isTraceEnabled to LogFileKey (#5499)
There are two trace statements that use Arrays.toString() as an argument. The methods where these log statements are found are used frequently in log recovery and the call to Arrays.toString may be unnecessary if trace logging is disabled.
1 parent 6c7f6d2 commit c2df3ba

File tree

1 file changed

+7
-3
lines changed
  • server/tserver/src/main/java/org/apache/accumulo/tserver/logger

1 file changed

+7
-3
lines changed

server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,9 @@ private byte[] formatRow(int tabletId, long seq) {
293293
row[11] = (byte) ((seq >>> 8) & mask);
294294
row[12] = (byte) (seq & mask);
295295

296-
log.trace("Convert {} {} {} to row {}", event, tabletId, seq, Arrays.toString(row));
296+
if (log.isTraceEnabled()) {
297+
log.trace("Convert {} {} {} to row {}", event, tabletId, seq, Arrays.toString(row));
298+
}
297299
return row;
298300
}
299301

@@ -347,8 +349,10 @@ public static LogFileKey fromKey(Key key) {
347349
if (eventType(logFileKey.event) != rowParts[0]) {
348350
throw new AssertionError("Event in row differs from column family. Key: " + key);
349351
}
350-
log.trace("From row {} get {} {} {}", Arrays.toString(rowParts), logFileKey.event,
351-
logFileKey.tabletId, logFileKey.seq);
352+
if (log.isTraceEnabled()) {
353+
log.trace("From row {} get {} {} {}", Arrays.toString(rowParts), logFileKey.event,
354+
logFileKey.tabletId, logFileKey.seq);
355+
}
352356

353357
// handle special cases of what is stored in the qualifier
354358
switch (logFileKey.event) {

0 commit comments

Comments
 (0)