Skip to content

admin check run command functionality #4892

Open
@kevinrr888

Description

@kevinrr888

Is your feature request related to a problem? Please describe.
#4807 added a new admin command admin check run which can be used to run various checks for problems in Accumulo. The checks don't do anything yet. The functionality for each of them should be added.

Describe the solution you'd like

  • Functionality for SYSTEM_CONFIG check
    • Check ZooKeeper locks for Accumulo server processes
    • Check ZooKeeper nodes for tables
    • Check the WAL metadata in ZooKeeper
  • Create and add functionality for a SERVER_CONFIG check
    • Check that all configured properties are valid (valid key and value)
    • Check that some expected required properties are present in the config (default value or user set)
  • Create and add functionality for a TABLE_LOCKS check (completed in [1])
    • Ensures that table and namespace locks are valid and are associated with a FATE op
  • Functionality for ROOT_METADATA check (completed in [1])
    • offline tablets
    • missing "columns"
    • invalid "columns"
  • Functionality for ROOT_TABLE check (completed in [1])
    • offline tablets
    • tablets for metadata table have no holes, valid (null) prev end row for first tablet, and valid (null) end row for last tablet
    • missing columns
    • invalid columns
  • Functionality for METADATA_TABLE check (completed in [1])
    • offline tablets
    • tablets for user tables (and scanref) have no holes, valid (null) prev end row for first tablet, and valid (null) end row for last tablet
    • missing columns
    • invalid columns
  • Functionality for SYSTEM_FILES check (completed in [1])
    • missing system files
  • Functionality for USER_FILES check (completed in [1])
    • missing user files
  • Existing checks currently done through other commands should be moved under the appropriate new check command.
    • Check for dangling fate locks (printed as info from accumulo admin fate print) (completed in [1])
    • accumulo admin checkTablets (completed in [1])
    • accumulo check-server-config
    • Note that accumulo check-compaction-config and accumulo check-accumulo-properties should not be moved since they just check the validity of a provided file, and do not operate on a running instance
  • Expand on AdminCheckIT as functionality is added. To complete this sub task, AdminCheckIT needs to check passing and failing cases for all the checks.

These should probably be completed over several PRs

The above list is subject to change

[1] #4957

Additional context
#4807 - added the check command
#4687 - detailed info about what should be checked

Metadata

Metadata

Assignees

Labels

blockerThis issue blocks any release version labeled on it.enhancementThis issue describes a new feature, improvement, or optimization.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions