Skip to content

Commit c2a3f83

Browse files
Temporarily bypass email_verified gate due to COmanage issue
1 parent b40df84 commit c2a3f83

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

pkg/service/identity_resolver.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,10 @@ func (s *Service) linkBySub(ctx context.Context, claims *identity.Claims) (*mode
139139
"email", claims.Email,
140140
"email_verified", claims.EmailVerified,
141141
)
142-
if !claims.EmailVerified || claims.Email == "" {
142+
// TODO: restore the email_verified gate once the CILogon test issuer +
143+
// COmanage LDAP provisioner start returning email_verified=true.
144+
// if !claims.EmailVerified || claims.Email == "" {
145+
if claims.Email == "" {
143146
return nil, identity.ErrEmailNotVerified
144147
}
145148
user, err := s.users.FindByEmail(ctx, claims.Email)

pkg/service/identity_resolver_integration_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,8 @@ func TestResolveCaller_EmailFallback_HappyPath_LinksAndActivates(t *testing.T) {
127127
}
128128

129129
func TestResolveCaller_EmailFallback_RefusesUnverifiedEmail(t *testing.T) {
130+
// TODO: re-enable when the email_verified gate is restored in linkBySub.
131+
t.Skip("email_verified gate temporarily bypassed pending COmanage fix")
130132
database := setupTestDB(t)
131133
svc := newTestService(database)
132134
seedPendingUserWithEmail(t, database, "pending@example.edu")

0 commit comments

Comments
 (0)