Add data-testid attributes to key UI components for unit test and automation tests #43736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
bbovenzi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue #43381 by adding
data-testidattributes to key UI components to improve stability and reliability for automated testing and external tools.Why This Change?
Currently, UI lacks reliable identifiers for DOM elements, making automation difficult and unstable. Using sibling and child selectors is not a dependable approach. Adding
data-testidattributes provides a robust solution, allowing automation frameworks and external tools to interact with UI elements consistently.Testing
Verified that the added
data-testidattributes do not interfere with the UI's functionality.Conducted tests to ensure elements are correctly identified and manipulated by automation scripts.
Related Issue
Fixes Issue #43381.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.