Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new dateformatter #44108

Closed
wants to merge 1 commit into from
Closed

Conversation

iprithv
Copy link

@iprithv iprithv commented Nov 17, 2024

Fixes #44033

Copy link

boring-cyborg bot commented Nov 17, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Comment on lines +62 to 64
def format_datetime_zulu(dt):
return dt.strftime(ZULU_STR_FORMAT).replace('+0000', 'Z')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the only file we need to edit. Can you probably place this utility somewhere under airflow/tests_common/test_utils and reuse it across other files?

For instance, also check for test_assets.py

ZULU_STR_FORMAT = '%Y-%m-%dT%H:%M:%S%z'


def format_datetime_zulu(dt):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def format_datetime_zulu(dt):
def format_datetime_zulu(dt: datetime) -> str:

@amoghrajesh
Copy link
Contributor

@iprithv I also see static checks failing. We have a pre-commit to maintain quality standards. You can install pre-commit using this: https://github.com/apache/airflow/blob/d43052e53bcf9bd8772484b8be4590f869932330/contributing-docs/03_contributors_quick_start.rst#configuring-pre-commit

Copy link

github-actions bot commented Jan 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 6, 2025
@github-actions github-actions bot closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a date formatter for new public API test cases
3 participants