-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 | Add UI Auth Links Endpoint #47662
AIP-84 | Add UI Auth Links Endpoint #47662
Conversation
91407b2
to
1da7c84
Compare
There's a CI issue and is (probably) fixed in the main branch. rebased the branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
e66cd3c
to
917a7a8
Compare
We should catch when the FAB provider isn't being used: cc @vincbeck ![]() |
|
Also, I am not saying this is wrong but do we want to expose it as API? We cannot pass it as config? Using an API would mean latency, so these additional links would be added to the menu after a small delay |
I'm experiencing the same error as Brent. I suspect that the |
Let me checkout the code and try |
You're right, I missed that. I'll create a PR to fix it |
Thanks ! I will rebase this PR after the fix being merged. |
917a7a8
to
d933d74
Compare
merged #47688 and rebase this branch from the main branch |
e6d3194
to
423824c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, working
closes: #47457
What
Add
/ui/auth/links
endpoint