Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 | Add UI Auth Links Endpoint #47662

Merged

Conversation

jason810496
Copy link
Member

closes: #47457

What

Add /ui/auth/links endpoint

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Mar 12, 2025
@Lee-W Lee-W force-pushed the feature/AIP-84/add-ui-auth-endpoint branch from 91407b2 to 1da7c84 Compare March 12, 2025 09:16
@Lee-W
Copy link
Member

Lee-W commented Mar 12, 2025

There's a CI issue and is (probably) fixed in the main branch. rebased the branch

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jason810496 jason810496 force-pushed the feature/AIP-84/add-ui-auth-endpoint branch 3 times, most recently from e66cd3c to 917a7a8 Compare March 12, 2025 13:12
@bbovenzi
Copy link
Contributor

bbovenzi commented Mar 12, 2025

We should catch when the FAB provider isn't being used: cc @vincbeck

Screenshot 2025-03-12 at 10 34 49 AM

@vincbeck
Copy link
Contributor

We should catch when the FAB provider isn't being used: cc @vincbeck

Screenshot 2025-03-12 at 10 34 49 AM

get_auth_manager returns the auth manager configured in the environment. So that should work regardless of the auth manager used. When do you get this error message?

@vincbeck
Copy link
Contributor

Also, I am not saying this is wrong but do we want to expose it as API? We cannot pass it as config? Using an API would mean latency, so these additional links would be added to the menu after a small delay

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Mar 12, 2025

I'm experiencing the same error as Brent. I suspect that the url_for method tries to use the flask current_app which is not set in our fastapi context.

@vincbeck
Copy link
Contributor

I'm experiencing the same error as Brent. I suspect that the url_for method tries to use the flask current_app which is not set in our fastapi context.

Let me checkout the code and try

@vincbeck
Copy link
Contributor

I'm experiencing the same error as Brent. I suspect that the url_for method tries to use the flask current_app which is not set in our fastapi context.

You're right, I missed that. I'll create a PR to fix it

@vincbeck
Copy link
Contributor

#47688

@jason810496
Copy link
Member Author

jason810496 commented Mar 13, 2025

#47688

Thanks ! I will rebase this PR after the fix being merged.

@Lee-W Lee-W force-pushed the feature/AIP-84/add-ui-auth-endpoint branch from 917a7a8 to d933d74 Compare March 13, 2025 10:12
@Lee-W
Copy link
Member

Lee-W commented Mar 13, 2025

merged #47688 and rebase this branch from the main branch

@Lee-W Lee-W force-pushed the feature/AIP-84/add-ui-auth-endpoint branch from e6d3194 to 423824c Compare March 13, 2025 11:29
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, working

@pierrejeambrun pierrejeambrun merged commit 6861661 into apache:main Mar 13, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-84 Add ui auth endpoint to expose FAB links from NavBar
5 participants