Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84 Move public api under /api/v2 #47760

Merged
merged 13 commits into from
Mar 19, 2025
Merged

AIP-84 Move public api under /api/v2 #47760

merged 13 commits into from
Mar 19, 2025

Conversation

prabhusneha
Copy link
Contributor

Closes: #47624

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Mar 14, 2025
pierrejeambrun
pierrejeambrun reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lets rebase and solve conflicts to run the CI

@prabhusneha prabhusneha force-pushed the rename_public_api_to_v2 branch from 4ec5384 to 545801c Compare March 14, 2025 12:45
@pierrejeambrun
Copy link
Member

I think we are missing some occurences in:

  • airflow/ui/dev/index.html|7 col 66|
  • clients/python/test_python_client.py|69 col 32| host="http://localhost:8080/public",
  • docker_tests/test_docker_compose_quick_start.py|94 col 80| method: str, path: str, base_url: str = f"http://{DOCKER_COMPOSE_HOST_PORT}/public", **kwargs
  • airflow/api_fastapi/app.py|76 col 65| description="Airflow API. All endpoints located under /public can be used safely, are stable and backward compatible. "
  • airflow/api_fastapi/auth/managers/simple/ui/dev/index.html|6 col 66|

@prabhusneha
Copy link
Contributor Author

I am fixing the conflicts and reopening.

@prabhusneha prabhusneha reopened this Mar 14, 2025
@prabhusneha prabhusneha force-pushed the rename_public_api_to_v2 branch from 15e32d4 to d8161ab Compare March 14, 2025 14:01
@prabhusneha
Copy link
Contributor Author

I think we are missing some occurences in:

  • airflow/ui/dev/index.html|7 col 66|
  • clients/python/test_python_client.py|69 col 32| host="http://localhost:8080/public",
  • docker_tests/test_docker_compose_quick_start.py|94 col 80| method: str, path: str, base_url: str = f"http://{DOCKER_COMPOSE_HOST_PORT}/public", **kwargs
  • airflow/api_fastapi/app.py|76 col 65| description="Airflow API. All endpoints located under /public can be used safely, are stable and backward compatible. "
  • airflow/api_fastapi/auth/managers/simple/ui/dev/index.html|6 col 66|

Made the required changes and resolved conflicts.

pierrejeambrun
pierrejeambrun reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs more work I guess, some tests are failing

@prabhusneha
Copy link
Contributor Author

Working on changing it to /api/v2 and fixing the CI.

@prabhusneha prabhusneha force-pushed the rename_public_api_to_v2 branch from d8161ab to ee97839 Compare March 19, 2025 07:39
@prabhusneha
Copy link
Contributor Author

@pierrejeambrun Please take a look.
Modified to /api/v2 and CI is green now.

pierrejeambrun
pierrejeambrun reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, beside comments Ash comments

@pierrejeambrun pierrejeambrun changed the title AIP-84 Move public api under /v2 AIP-84 Move public api under /api/v2 Mar 19, 2025
@prabhusneha
Copy link
Contributor Author

Looking good to me, beside comments Ash comments

As mentioned, will create a follow up PR to address the comments by @ashb

@jedcunningham jedcunningham mentioned this pull request Mar 19, 2025
Open
1 task
bugraoz93
bugraoz93 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Ash on generalizing the test paths to eliminate huge updates if needed.

@jedcunningham jedcunningham merged commit cae2232 into apache:main Mar 19, 2025
89 checks passed
@jedcunningham jedcunningham deleted the rename_public_api_to_v2 branch March 19, 2025 23:51
tyrellcurry pushed a commit to tyrellcurry/airflow that referenced this pull request Mar 21, 2025
@prabhusneha @tyrellcurry
AIP-84 Move public api under /api/v2 (apache#47760)
2a3b910
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
@prabhusneha @agupta01
AIP-84 Move public api under /api/v2 (apache#47760)
ebb3166
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Mar 22, 2025
@prabhusneha @shubham-pyc
AIP-84 Move public api under /api/v2 (apache#47760)
a16b993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun left review comments

@jedcunningham jedcunningham jedcunningham approved these changes

@ashb ashb ashb approved these changes

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton

@jscheffl jscheffl Awaiting requested review from jscheffl

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-84 Move public api under /v2
6 participants
@prabhusneha @pierrejeambrun @ashb @tirkarthi @bugraoz93 @jedcunningham