Suppress “deprecation” and “unused” warnings

Author: Gintas Grigelionis

src/java/org/apache/ivy/core/settings/IvySettings.java

@@ -316,6 +316,7 @@ private synchronized void addSystemProperties() {
      *
      * @param remote boolean
      */
+    @SuppressWarnings("deprecation")
     public synchronized void configureRepositories(boolean remote) {
         if (!repositoriesConfigured) {
             Properties props = new Properties();

src/java/org/apache/ivy/core/settings/XmlSettingsParser.java

@@ -148,6 +148,7 @@ public File resolveFile(String path, String filename) {
         doParse(settings);
     }
 
+    @SuppressWarnings("deprecation")
     private void doParse(URL settingsUrl) throws IOException, ParseException {
         this.settings = settingsUrl;
         InputStream stream = null;
@@ -319,6 +320,7 @@ private void cachesStarted(String qName, Map<String, String> attributes) {
         }
     }
 
+    @SuppressWarnings("deprecation")
     private void settingsStarted(String qName, Map<String, String> attributes) {
         if ("conf".equals(qName) && !deprecatedMessagePrinted) {
             Message.deprecated("'conf' is deprecated, use 'settings' instead (" + settings + ")");

src/java/org/apache/ivy/plugins/parser/m2/MavenVersionRangeParser.java

@@ -80,7 +80,6 @@ static boolean rangeAccepts(final String range, final String value) {
         return parsedRange != null && parsedRange.accepts(valToCompare);
     }
 
-
     private static Range parse(final String rangeValue) {
         if (rangeValue == null || rangeValue.trim().isEmpty()) {
             return null;
@@ -156,8 +155,11 @@ private interface Range {
 
     private static final class BasicRange implements Range {
         private final DeweyDecimal lowerBound;
+
         private final DeweyDecimal upperBound;
+
         private final boolean lowerInclusive;
+
         private final boolean upperInclusive;
 
         private BasicRange(final DeweyDecimal lowerBound, final boolean lowerInclusive,
@@ -216,6 +218,7 @@ private static final class DeweyDecimal {
          *
          * @param components an array of integer components.
          */
+        @SuppressWarnings("unused")
         public DeweyDecimal(final int[] components) {
             this.components = new int[components.length];
             System.arraycopy(components, 0, this.components, 0, components.length);
@@ -242,11 +245,11 @@ public DeweyDecimal(final String string)
 
                 components[i] = Integer.parseInt(component);
 
-                //Strip '.' token
+                // Strip '.' token
                 if (tokenizer.hasMoreTokens()) {
                     tokenizer.nextToken();
 
-                    //If it ended in a dot, throw an exception
+                    // If it ended in a dot, throw an exception
                     if (!tokenizer.hasMoreTokens()) {
                         throw new NumberFormatException("DeweyDecimal ended in a '.'");
                     }
@@ -259,6 +262,7 @@ public DeweyDecimal(final String string)
          *
          * @return the number of components in dewey decimal
          */
+        @SuppressWarnings("unused")
         public int getSize() {
             return components.length;
         }
@@ -269,6 +273,7 @@ public int getSize() {
          * @param index the index of components
          * @return the value of component at index
          */
+        @SuppressWarnings("unused")
         public int get(final int index) {
             return components[index];
         }
@@ -393,6 +398,7 @@ public String toString() {
          * @return result
          * @see java.lang.Comparable#compareTo(Object)
          */
+        @SuppressWarnings("unused")
         public int compareTo(DeweyDecimal other) {
             final int max = Math.max(other.components.length, components.length);
             for (int i = 0; i < max; i++) {

src/java/org/apache/ivy/plugins/parser/m2/PomReader.java

@@ -118,6 +118,7 @@ public class PomReader {
 
     private final Element parentElement;
 
+    @SuppressWarnings("deprecation")
     public PomReader(final URL descriptorURL, final Resource res) throws IOException, SAXException {
         InputStream stream = new AddDTDFilterInputStream(
                 URLHandlerRegistry.getDefault().openStream(descriptorURL));
@@ -373,6 +374,7 @@ public PomDependencyMgtElement(PomDependencyMgtElement copyFrom) {
 
         /*
          * (non-Javadoc)
+         *
          * @see org.apache.ivy.plugins.parser.m2.PomDependencyMgt#getGroupId()
          */
         public String getGroupId() {
@@ -382,6 +384,7 @@ public String getGroupId() {
 
         /*
          * (non-Javadoc)
+         *
          * @see org.apache.ivy.plugins.parser.m2.PomDependencyMgt#getArtifaceId()
          */
         public String getArtifactId() {
@@ -391,6 +394,7 @@ public String getArtifactId() {
 
         /*
          * (non-Javadoc)
+         *
          * @see org.apache.ivy.plugins.parser.m2.PomDependencyMgt#getVersion()
          */
         public String getVersion() {
@@ -539,12 +543,17 @@ public class PomProfileElement {
         private static final String ACTIVE_BY_DEFAULT_ELEMENT = "activeByDefault";
 
         private static final String OS = "os";
+
         private static final String FAMILY = "family";
+
         private static final String VERSION = "version";
+
         private static final String ARCH = "arch";
 
         private static final String FILE = "file";
+
         private static final String MISSING = "missing";
+
         private static final String EXISTS = "exists";
 
         private static final String JDK = "jdk";

src/java/org/apache/ivy/plugins/repository/url/URLResource.java

@@ -74,6 +74,7 @@ public long getLastModified() {
         return lastModified;
     }
 
+    @SuppressWarnings("deprecation")
     private void init() {
         final URLHandler handler = URLHandlerRegistry.getDefault();
         final URLInfo info;
@@ -114,6 +115,7 @@ public boolean isLocal() {
         return url.getProtocol().equals("file");
     }
 
+    @SuppressWarnings("deprecation")
     public InputStream openStream() throws IOException {
         final URLHandler handler = URLHandlerRegistry.getDefault();
         if (handler instanceof TimeoutConstrainedURLHandler) {

src/java/org/apache/ivy/util/FileUtil.java

@@ -200,6 +200,7 @@ public static boolean deepCopy(File src, File dest, CopyProgressListener l, bool
         return true;
     }
 
+    @SuppressWarnings("deprecation")
     public static void copy(final URL src, final File dest, final CopyProgressListener listener,
                             final TimeoutConstraint timeoutConstraint) throws IOException {
         final URLHandler handler = URLHandlerRegistry.getDefault();
@@ -210,6 +211,7 @@ public static void copy(final URL src, final File dest, final CopyProgressListen
         handler.download(src, dest, listener);
     }
 
+    @SuppressWarnings("deprecation")
     public static void copy(final File src, final URL dest, final CopyProgressListener listener,
                             final TimeoutConstraint timeoutConstraint) throws IOException {
         final URLHandler handler = URLHandlerRegistry.getDefault();
@@ -680,6 +682,7 @@ public boolean markSupported() {
 
     private static final class DissectedPath {
         private final String root;
+
         private final String remainingPath;
 
         private DissectedPath(final String root, final String remainingPath) {

src/java/org/apache/ivy/util/XMLHelper.java

@@ -117,6 +117,7 @@ public static void parse(URL xmlURL, URL schema, DefaultHandler handler) throws
     }
 
     public static void parse(URL xmlURL, URL schema, DefaultHandler handler, LexicalHandler lHandler)
+    @SuppressWarnings("deprecation")
             throws SAXException, IOException, ParserConfigurationException {
         InputStream xmlStream = URLHandlerRegistry.getDefault().openStream(xmlURL);
         try {
@@ -142,6 +143,7 @@ public static void parse(InputSource xmlStream, URL schema, DefaultHandler handl
         parse(xmlStream, schema, handler, lHandler, true);
     }
 
+    @SuppressWarnings("deprecation")
     public static void parse(InputSource xmlStream, URL schema, DefaultHandler handler,
             LexicalHandler lHandler, boolean loadExternalDtds) throws SAXException, IOException,
             ParserConfigurationException {

src/java/org/apache/ivy/util/url/AbstractURLHandler.java

@@ -30,9 +30,11 @@
 import java.util.zip.GZIPInputStream;
 import java.util.zip.Inflater;
 import java.util.zip.InflaterInputStream;
+
 import org.apache.ivy.Ivy;
 import org.apache.ivy.core.settings.TimeoutConstraint;
 
+@SuppressWarnings("deprecation")
 public abstract class AbstractURLHandler implements URLHandler {
 
     private static final Pattern ESCAPE_PATTERN = Pattern.compile("%25([0-9a-fA-F][0-9a-fA-F])");
@@ -70,7 +72,6 @@ public long getLastModified(final URL url, final int timeout) {
         return getURLInfo(url, timeout).getLastModified();
     }
 
-
     protected String getUserAgent() {
         return System.getProperty("http.agent", "Apache Ivy/" + Ivy.getIvyVersion());
     }

src/java/org/apache/ivy/util/url/ApacheURLLister.java

@@ -101,6 +101,7 @@ public List<URL> listFiles(URL url) throws IOException {
      * @throws IOException
      *             If an error occurs retrieving the HTML.
      */
+    @SuppressWarnings("deprecation")
     public List<URL> retrieveListing(URL url, boolean includeFiles, boolean includeDirectories)
             throws IOException {
         List<URL> urlList = new ArrayList<>();

src/java/org/apache/ivy/util/url/BasicURLHandler.java

@@ -50,31 +50,37 @@ private HttpStatus() {
         }
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public URLInfo getURLInfo(final URL url) {
         return this.getURLInfo(url, null);
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public URLInfo getURLInfo(final URL url, final int timeout) {
         return this.getURLInfo(url, createTimeoutConstraints(timeout));
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public boolean isReachable(final URL url, final TimeoutConstraint timeoutConstraint) {
         return this.getURLInfo(url, timeoutConstraint).isReachable();
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public long getContentLength(final URL url, final TimeoutConstraint timeoutConstraint) {
         return this.getURLInfo(url, timeoutConstraint).getContentLength();
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public long getLastModified(final URL url, final TimeoutConstraint timeoutConstraint) {
         return this.getURLInfo(url, timeoutConstraint).getLastModified();
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public URLInfo getURLInfo(final URL url, final TimeoutConstraint timeoutConstraint) {
         // Install the IvyAuthenticator