How to disable AutoCommit in the Snowflake driver?

[felipecrv]

What would you like help with?

From Rust, when calling Connection::commit() I get:

Error { message: "[Snowflake] Cannot commit when autocommit is enabled", status: InvalidState, vendor_code: -2147483648, sqlstate: [0, 0, 0, 0, 0], details: Some([]) }

And when I try to disable auto commit [1], I get:

Error { message: "[Snowflake] Unknown connection option 'adbc.connection.autocommit'", status: NotImplemented, vendor_code: -2147483648, sqlstate: [0, 0, 0, 0, 0], details: Some([]) }

If the driver doesn't support auto-commit, can it understand that auto-commit is disabled and let Connection::commit() calls work?

[1]

conn.set_option(OptionConnection::AutoCommit, OptionValue::Int(0))?;

[felipecrv]

cc @zeroshade

[CurtHagenlocher]

This should be implemented. Have you tried setting it to the string "disabled" instead of an integer 0?

[felipecrv]

This should be implemented. Have you tried setting it to the string "disabled" instead of an integer 0?

Same problem: "[Snowflake] Unknown connection option 'adbc.connection.autocommit'"

[lidavidm]

It should be "false" but this is implemented and tested.

[lidavidm]

Does Rust not define constants and/or a higher level setter for this?

[felipecrv]

Does Rust not define constants and/or a higher level setter for this?

There is a constant, but only now I found an example in the tests

    connection
        .set_option(OptionConnection::AutoCommit, "false".into())
        .unwrap();

The value doesn't matter though. The Snowflake driver simply does not recognize the option.

[CurtHagenlocher]

It should be "false" but this is implemented and tested.

Ah, I confused the symbol name in the header with the symbol value.

The value doesn't matter though. The Snowflake driver simply does not recognize the option.

It's been too long since I looked at the Snowflake code, but I can see where that error is being produced and it's not clear to me how the delegation to the base implementation would work.

[felipecrv]

It's been too long since I looked at the Snowflake code, but I can see where that error is being produced and it's not clear to me how the delegation to the base implementation would work.

I did the same thing and was puzzled like you. :D

[CurtHagenlocher]

It looks like the delegation is actually going in the opposite direction; starting in the shared code and then going from there to the Snowflake-specific code.

[lidavidm]

Hmm, and it looks like we only test that the option fails...

[CurtHagenlocher]

While I thought we had tested this from C#, perhaps I was mistaken. Is it possible that going through the C API causes the Snowflake-specific implementation to be called instead of the "outer" implementation which handles autocommit?

[lidavidm]

It shouldn't, since we're exporting what should be the same interface method that Go would use. But I'll let Matt chime in on what's going on here (which seems rather odd)