Skip to content

Commit a95ac9f

Browse files
committed
Lint and sort
1 parent 49eb4ef commit a95ac9f

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2448,9 +2448,10 @@ macro(build_substrait)
24482448

24492449
add_library(substrait STATIC ${SUBSTRAIT_SOURCES})
24502450
# Match Protobuf's visibility because target contains generated Protobuf code
2451-
set_target_properties(substrait PROPERTIES POSITION_INDEPENDENT_CODE ON
2452-
CXX_VISIBILITY_PRESET hidden
2453-
VISIBILITY_INLINES_HIDDEN ON)
2451+
set_target_properties(substrait
2452+
PROPERTIES POSITION_INDEPENDENT_CODE ON
2453+
CXX_VISIBILITY_PRESET hidden
2454+
VISIBILITY_INLINES_HIDDEN ON)
24542455
target_compile_options(substrait PRIVATE "${SUBSTRAIT_SUPPRESSED_FLAGS}")
24552456
target_include_directories(substrait PUBLIC ${SUBSTRAIT_INCLUDES})
24562457
target_link_libraries(substrait PUBLIC ${ARROW_PROTOBUF_LIBPROTOBUF})
@@ -3962,7 +3963,9 @@ function(build_orc)
39623963
set(ORC_CMAKE_ARGS
39633964
${EP_COMMON_CMAKE_ARGS}
39643965
"-DCMAKE_CXX_FLAGS=${ORC_CXX_FLAGS}"
3966+
-DCMAKE_CXX_VISIBILITY_PRESET=hidden
39653967
"-DCMAKE_INSTALL_PREFIX=${ORC_PREFIX}"
3968+
-DCMAKE_VISIBILITY_INLINES_HIDDEN=ON
39663969
-DSTOP_BUILD_ON_WARNING=OFF
39673970
-DBUILD_LIBHDFSPP=OFF
39683971
-DBUILD_JAVA=OFF
@@ -3986,9 +3989,7 @@ function(build_orc)
39863989
"-DZSTD_LIBRARY=$<TARGET_FILE:${ARROW_ZSTD_LIBZSTD}>"
39873990
"-DZLIB_HOME=${ORC_ZLIB_ROOT}"
39883991
"-DZLIB_INCLUDE_DIR=$<TARGET_PROPERTY:ZLIB::ZLIB,INTERFACE_INCLUDE_DIRECTORIES>"
3989-
"-DZLIB_LIBRARY=$<TARGET_FILE:ZLIB::ZLIB>"
3990-
-DCMAKE_CXX_VISIBILITY_PRESET=hidden
3991-
-DCMAKE_VISIBILITY_INLINES_HIDDEN=ON)
3992+
"-DZLIB_LIBRARY=$<TARGET_FILE:ZLIB::ZLIB>")
39923993

39933994
# Work around CMake bug
39943995
file(MAKE_DIRECTORY ${ORC_INCLUDE_DIR})

0 commit comments

Comments
 (0)