GH-48861: [CI] Fix wrong smtplib.SMTP.send_message usage
#48876
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
force-pushed
the
ci-nightly-report
branch
from
886055e to
315ea3b
Compare
raulcd
approved these changes
Jan 16, 2026
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks @kou !
I've validated the smtplib documentation, this seems good.
https://docs.python.org/es/dev/library/smtplib.html#smtplib.SMTP.send_message
github-actions
bot
added
awaiting merge
raulcd
changed the title
smtplib.SMTP.send_message usagesmtplib.SMTP.send_message usage
raulcd
changed the title
smtplib.SMTP.send_message usage smtplib.SMTP.send_message usage
|
|
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6ec9162. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
https://docs.python.org/3/library/smtplib.html#smtplib.SMTP.sendmail uses the third argument as e-mail content but https://docs.python.org/3/library/smtplib.html#smtplib.SMTP.send_message uses the first argument as e-mail.
What changes are included in this PR?
Are these changes tested?
Yes. I sent a test e-mail manually.
Are there any user-facing changes?
No.