Skip to content

Commit 1443f18

Browse files
committed
refactor
1 parent f0af7c5 commit 1443f18

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

lang/java/gradle-plugin/src/main/kotlin/eu/eventloopsoftware/avro/gradle/plugin/AvroGradlePlugin.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ abstract class AvroGradlePlugin : Plugin<Project> {
3838

3939
when (SchemaType.valueOf(schemaType)) {
4040
SchemaType.schema -> {
41-
val compileAvroSchemaTask = addSchemaTask(extension, project)
42-
val compileTestAvroSchemaTask = addSchemaTestTask(extension, project)
41+
val compileAvroSchemaTask = registerSchemaTask(extension, project)
42+
val compileTestAvroSchemaTask = registerSchemaTestTask(extension, project)
4343
registerPluginHook(project, compileAvroSchemaTask, compileTestAvroSchemaTask)
4444
}
4545

@@ -64,7 +64,7 @@ abstract class AvroGradlePlugin : Plugin<Project> {
6464
}
6565
}
6666

67-
private fun addSchemaTask(extension: AvroGradlePluginExtension, project: Project) =
67+
private fun registerSchemaTask(extension: AvroGradlePluginExtension, project: Project) =
6868
project.tasks.register("avroGenerateJavaClasses", CompileAvroSchemaTask::class.java) { compileSchemaTask ->
6969
addProperties(
7070
compileSchemaTask,
@@ -85,7 +85,7 @@ abstract class AvroGradlePlugin : Plugin<Project> {
8585
compileSchemaTask.runtimeClassPathFileCollection.from(project.configurations.getByName("runtimeClasspath").files)
8686
}
8787

88-
private fun addSchemaTestTask(extension: AvroGradlePluginExtension, project: Project) =
88+
private fun registerSchemaTestTask(extension: AvroGradlePluginExtension, project: Project) =
8989
project.tasks.register(
9090
"avroGenerateTestJavaClasses",
9191
CompileAvroSchemaTask::class.java,

lang/java/gradle-plugin/src/main/kotlin/eu/eventloopsoftware/avro/gradle/plugin/tasks/CompileAvroProtocolTask.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ abstract class CompileAvroProtocolTask : AbstractCompileTask() {
1616
@get:SkipWhenEmpty
1717
abstract val schemaFiles: ConfigurableFileCollection
1818

19-
@get:Input
20-
abstract val other: String
21-
2219
@TaskAction
2320
fun compileProtocol() {
2421
logger.info("Generating Java files from ${schemaFiles.files.size} Avro Protocol files...")

0 commit comments

Comments
 (0)