Skip to content

Commit cc53097

Browse files
authored
Fix spanner io hang by closing connections (#37327)
1 parent 337bb6d commit cc53097

File tree

1 file changed

+4
-3
lines changed
  • sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner

1 file changed

+4
-3
lines changed

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2101,9 +2101,10 @@ private static Dialect getDialect(SpannerConfig spannerConfig, PipelineOptions p
21012101
// Allow passing the credential from pipeline options to the getDialect() call.
21022102
SpannerConfig spannerConfigWithCredential =
21032103
buildSpannerConfigWithCredential(spannerConfig, pipelineOptions);
2104-
DatabaseClient databaseClient =
2105-
SpannerAccessor.getOrCreate(spannerConfigWithCredential).getDatabaseClient();
2106-
return databaseClient.getDialect();
2104+
try (SpannerAccessor sa = SpannerAccessor.getOrCreate(spannerConfigWithCredential)) {
2105+
DatabaseClient databaseClient = sa.getDatabaseClient();
2106+
return databaseClient.getDialect();
2107+
}
21072108
}
21082109

21092110
/**

0 commit comments

Comments
 (0)