Skip to content

Commit def076e

Browse files
committed
Address PR comments.
1 parent 0c36ae2 commit def076e

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

model/pipeline/src/main/proto/beam_runner_api.proto

+2-2
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@ message StandardPTransforms {
205205
// Represents mapping of main input window onto side input window.
206206
//
207207
// Side input window mapping function:
208-
// Input: KV<nonce, SideInputWindow>
209-
// Output: KV<nonce, MainInputWindow>
208+
// Input: KV<nonce, MainInputWindow>
209+
// Output: KV<nonce, SideInputWindow>
210210
//
211211
// For each main input window, the side input window is returned. The
212212
// nonce is used by a runner to associate each input with its output.

sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMappingFnRunner.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
* <p>Side input window mapping function:
3838
*
3939
* <ul>
40-
* <li>Input: {@code KV<nonce, SideInputWindow>}
41-
* <li>Output: {@code KV<nonce, MainInputWindow>}
40+
* <li>Input: {@code KV<nonce, MainInputWindow>}
41+
* <li>Output: {@code KV<nonce, SideInputWindow>}
4242
* </ul>
4343
*
4444
* <p>For each main input window, the side input window is returned. The nonce is used by a runner

sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMergingFnRunner.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ static <T, W extends BoundedWindow> WindowMergingFnRunner<T, W> create(WindowFn<
8787
if (windowFn.isNonMerging()) {
8888
return new NonMergingWindowFnRunner();
8989
} else {
90-
return new MergingWindowFnRunner(windowFn);
90+
return new MergingViaWindowFnRunner(windowFn);
9191
}
9292
}
9393

@@ -118,14 +118,14 @@ KV<T, KV<Iterable<W>, Iterable<KV<W, Iterable<W>>>>> mergeWindows(
118118
}
119119

120120
/** An implementation which uses a {@link WindowFn} to merge windows. */
121-
private static class MergingWindowFnRunner<T, W extends BoundedWindow>
121+
private static class MergingViaWindowFnRunner<T, W extends BoundedWindow>
122122
extends WindowMergingFnRunner<T, W> {
123123
private final WindowFn<?, W> windowFn;
124124
private final WindowFn<?, W>.MergeContext mergeContext;
125125
private Collection<W> currentWindows;
126126
private List<KV<W, Collection<W>>> mergedWindows;
127127

128-
private MergingWindowFnRunner(WindowFn<?, W> windowFn) {
128+
private MergingViaWindowFnRunner(WindowFn<?, W> windowFn) {
129129
this.windowFn = windowFn;
130130
this.mergedWindows = new ArrayList<>();
131131
this.currentWindows = new ArrayList<>();

0 commit comments

Comments
 (0)